polarsource / polar

An Open Source Lemon Squeezy alternative with better pricing! Get paid coding on your passion.
https://polar.sh
Apache License 2.0
2.91k stars 121 forks source link

server: differentiate email for subscription cancelation #3917

Closed codenoid closed 1 month ago

codenoid commented 1 month ago

On the existing code, Polar send the subscription created email for when the even is subscription cancelation.

vercel[bot] commented 1 month ago

@codenoid is attempting to deploy a commit to the polar-sh Team on Vercel.

A member of the Team first needs to authorize it.

codenoid commented 1 month ago

Sorry for the gipiti comment, 3AM Pull Request kinda hit different

frankie567 commented 1 month ago

Hey @codenoid 👋

Thank you for this! So, you mean that a confirmation email is sent after cancelling a subscription plan? Did you experience this? That sounds really unexpected 😅

codenoid commented 1 month ago

@frankie567 correct, that was what happen when I testing (in polar.sh) to cancel my subscription

frankie567 commented 1 month ago

Thank you @codenoid, I've checked on my side and indeed experienced the same behavior; really appreciate your report on this!

I'll have a look at the PR ;)

frankie567 commented 1 month ago

Thank you for this @codenoid, that's really helpful 🙏

sentry-io[bot] commented 1 month ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

codenoid commented 1 month ago

What happen 🤔

is it because the date format part? (that should be date('%B %d, %Y'))

frankie567 commented 1 month ago

date is not a builtin filter in Jinja2 🙂 Fixed and added a unit test here: #3948