Closed CHarpprecht closed 3 months ago
I deleted all the .lower()
(except for 2 occurrences for checking the LIST model), and now I can import LCIs with capital letters in their names, and the database is functional for LCA calculations
Both suggestions now included (extended error message and removed the lower-casing of name of imported inventories).
It seems to me that right now it is not possible to import LCIs for external scenarios which contain capital letters in their product name or process name:
I get the following error:
The function
'check_inventories'
applies a lot of'.lower()'
to dataset names, e.g.:I think that this causes the error: the datasets cannot be found in the databases anymore, since they are all lower case now. However, also some ecoinvent processes do contain capitalized letters, e.g. for activities containing strings like:
Wouldn't it make sense to allow for capital letters in inventory names? This would give the user more freedom for naming processes, using abbreviations etc. (and potentially avoid future issues with the capitalized ecoinvent names?).
Another minor suggestion:
To make the error message more informative in lines 263-264, I suggest extending it a bit, e.g. via: