polca / premise

Coupling Integrated Assessment Models output with Life Cycle Assessment.
BSD 3-Clause "New" or "Revised" License
100 stars 45 forks source link

add biosphere_name argument to NewDatabase #167

Closed TimoDiepers closed 1 month ago

TimoDiepers commented 1 month ago

The biosphere_name is a class variable in NewDatabase, but there is no optional argument for the biosphere_name in the init. Instead, the check_presence_of_biosphere_database function checks for the default name "biosphere3" and asks for user input if it's not present.

I think adding biosphere_name as an optional argument to NewDatabase would be nice to avoid stopping for user inputs when running a script. In my case, I used the ecoinvent_interface to get ei releases. There, the default name of the biosphere is not "biosphere3" anymore, so for me the name input always popped up when creating the premise dbs.

The default behavior of the proposed solution is the same as before, It just allows for defining a custom biosphere name beforehand.