"Normal" Render Mode incorrect size in Gens 10a, fine in 10

[GoogleCodeExporter]

Normal render mode is slightly small and bordered for some reason in 10a.
This problem does not exist in 10. If more information is required, I can
take screenshots and post them.

Original issue reported on code.google.com by farr...@bluetoaster.net on 10 Aug 2008 at 6:19

[GoogleCodeExporter]

Looks the same as always to me, and I don't think the code for normal rendering 
(or
any rendering) has changed between 10 and 10a. The only thing that comes to 
mind is
that maybe your menu text font is much wider than normal and changing "Graphic" 
to
"Graphics" made the menu wrap. Either that or you're testing the two versions 
with
two different config files.

Screenshots would be helpful.

Original comment by nitsuja-@hotmail.com on 10 Aug 2008 at 6:44

• Changed state: New

[GoogleCodeExporter]

That is exactly what has happened. The text font is the Vista non-Aero default 
also,
so this will likely occur for any Vista users also. Still, you requested 
screenshots
so here they are:

Gens 10: http://www.bluetoaster.net/tasvideos/gens/gens10fine.png
Gens 10a: http://www.bluetoaster.net/tasvideos/gens/gens10aproblem.png

Original comment by farr...@bluetoaster.net on 10 Aug 2008 at 6:53

[GoogleCodeExporter]

It looks like its caused due to changes in pluralization of the menu. Should be 
fixed
if we change Graphics to Video

Original comment by Upth...@gmail.com on 10 Aug 2008 at 8:59

[GoogleCodeExporter]

I made a hopefully longer-term fix to actually measure the width of the menu 
using
the current system menu font settings and prevent it from going multi-line. It 
works
for me, even if I change my menu font from size 8 to size 24, the game view 
stays the
same height. Can someone confirm that it works in Vista too? It should, but they
could easily have done something like randomly add 1 pixel to the width of all 
menus
just to break my code there.

Original comment by nitsuja-@hotmail.com on 10 Aug 2008 at 9:52

• Changed state: Accepted

[GoogleCodeExporter]

The problem persists.

Rev 84: http://www.bluetoaster.net/tasvideos/gens/gensr84problem.png

Original comment by farr...@bluetoaster.net on 10 Aug 2008 at 10:04

[GoogleCodeExporter]

Weird. What font is that, exactly? And can I see what it looks like if you 
double
your menu font size? Can you tell me what the value of Gens_Menu_Width is at 
the end
of Build_Main_Menu?

Original comment by nitsuja-@hotmail.com on 10 Aug 2008 at 10:10

[GoogleCodeExporter]

OK, it happens for me too if I use Segoe UI size 9 Bold, maybe I just forgot to 
apply
bold/italic before measuring.

Original comment by nitsuja-@hotmail.com on 10 Aug 2008 at 10:23

[GoogleCodeExporter]

Font: Segoe UI, Size: 9

The larger the font, the more fits onto the first line of the menu bar. Weird.

http://www.bluetoaster.net/tasvideos/gens/gensr84massivefont.png

in G_main.cpp:
4729    int extraSpace = size.cx;
4730    Gens_Menu_Width = extraSpace;

Original comment by farr...@bluetoaster.net on 10 Aug 2008 at 10:29

[GoogleCodeExporter]

OK, it's just a slight calculation error at this point. If necessary I can add a
little fudge factor amount to make the value high enough, but I'd like to 
calculate
it exactly if possible. I think the only remaining thing I'm having trouble 
figuring
out is how to calculate how much space Windows puts in-between menu items. For 
the
Windows XP menu font (Tahoma) it's exactly twice the width of an underscore
character, but for Segoe UI it's slightly different. It must be getting it from
somewhere, but I can't seem to find any relevant documentation...

Original comment by nitsuja-@hotmail.com on 10 Aug 2008 at 11:23

[GoogleCodeExporter]

I think I got it this time. Try Rev 89. If the problem is still there, resize 
the
window width until the exact pixel where the menu stops wrapping and show me 
both
screenshots, so I can get an idea of how far off it is.

Original comment by nitsuja-@hotmail.com on 11 Aug 2008 at 1:31

[GoogleCodeExporter]

http://www.bluetoaster.net/tasvideos/gens/gensr89fixed.png

Perfect. :)

Original comment by farr...@bluetoaster.net on 11 Aug 2008 at 1:38

[GoogleCodeExporter]

Original comment by farr...@bluetoaster.net on 11 Aug 2008 at 1:40

• Changed state: Fixed