poldrack / cogat

Cognitive Atlas
http://www.cognitiveatlas.org
13 stars 2 forks source link

identifier mismatch between cogat.owl 0.3.0 and 0.3.1 #22

Open tgbugs opened 6 years ago

tgbugs commented 6 years ago

I was reviewing the changes from 0.3.0 -> 0.3.1 so that I could update the version we import into the NIF-Ontology and discovered that there is a major mismatch between the identifiers.

Here is a diff which makes the issue easy to see.

All of neurolex/interlex and anyone who used them has the mapping from 3.0. Fortunately it doesn't look like it is too hard to fix in the existing owl file, but the fact that this has happened probably means that the generation script has a bug.

poldrack commented 6 years ago

sorry for delay on this - we have completely refactored the cognitive atlas site, and the ontology generation code will need some major changes to accomodate this. not sure when I can get to that...

On Sun, Dec 3, 2017 at 6:04 AM, Tom Gillespie notifications@github.com wrote:

I was reviewing the changes from 0.3.0 -> 0.3.1 so that I could update the version we import into the NIF-Ontology https://github.com/SciCrunch/NIF-Ontology/blob/master/ttl/external/cogat_v0.3.owl and discovered that there is a major mismatch between the identifiers.

Here is a diff https://gist.github.com/tgbugs/2ea553aae0f4be029fb0488a64b71d82 which makes the issue easy to see.

All of neurolex/interlex and anyone who used them has the mapping from 3.0. Fortunately it doesn't look like it is too hard to fix in the existing owl file, but the fact that this has happened probably means that the generation script has a bug.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/poldrack/cogat/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1KkG6BdD0P1lSZJR0lXlihkvjtj35Gks5s8qpxgaJpZM4QzuvS .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305

poldrack@stanford.edu http://www.poldracklab.org/

tgbugs commented 6 years ago

No worries. Is it ok if I align 0.3.1 with 0.3.0 and submit a pull request for the time being so that folks following the canonical ontology uri don't get confused?

poldrack commented 6 years ago

sure, sounds good, thanks!

On Sun, Dec 17, 2017 at 12:21 PM, Tom Gillespie notifications@github.com wrote:

No worries. Is it ok if I align 0.3.1 with 0.3.0 and submit a pull request for the time being so that folks following the canonical ontology uri don't get confused?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/poldrack/cogat/issues/22#issuecomment-352282484, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1KkCcALy54ttT7KeJGavVNLddxBNUgks5tBXfegaJpZM4QzuvS .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305

poldrack@stanford.edu http://www.poldracklab.org/