search

poldracklab / fitlins

Fit Linear Models to BIDS Datasets
https://fitlins.readthedocs.io
Apache License 2.0
76 stars 32 forks source link

Contrast names are modified in unexpected way #319

Closed adelavega closed 3 years ago

adelavega commented 3 years ago

In this model: https://neuroscout.org/builder/6jo4s

subtlexusfrequency_Lg10WF -> subtlexusfrequencyLg10Wf

and massiveauditorylexicaldecision_PhonLev -> massiveauditorylexicaldecisionPhonlev

Basically it looks as though the last capital letter in the contrast is lower cased.

The underscore makes sense, as this is snake_to_camel, but otherwise I'm not sure where this change occurs, and it causes some down stream inconsitencies

adelavega commented 3 years ago

Nevermind, looks like I was using a different snake_to_camel function elsewhere

effigies commented 3 years ago

I like an issue that's resolved before I've had a chance to look closely.

adelavega commented 3 years ago

I felt like I was going crazy, I copy pasted the code from fitlins and thought I got a different answer. I'm sure you know the feeling.

effigies commented 3 years ago

sitting on a lawn chair in my basement, smoking a cigarette and staring unblinkingly at the chipped plaster

"Wherever he is, @adelavega is going crazy."