poldracklab / fitlins

Fit Linear Models to BIDS Datasets
https://fitlins.readthedocs.io
Apache License 2.0
76 stars 32 forks source link

Adding a section on estimators #375

Closed Shotgunosine closed 2 years ago

pep8speaks commented 2 years ago

Hello @Shotgunosine, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. :beers: To test for issues locally, pip install flake8 and then run flake8 fitlins.

Comment last updated at 2022-07-22 20:30:26 UTC
codecov-commenter commented 2 years ago

Codecov Report

Merging #375 (20045e3) into dev (372e6d2) will decrease coverage by 0.08%. The diff coverage is 20.00%.

@@            Coverage Diff             @@
##              dev     #375      +/-   ##
==========================================
- Coverage   64.42%   64.34%   -0.09%     
==========================================
  Files          23       23              
  Lines        1816     1820       +4     
  Branches      343      345       +2     
==========================================
+ Hits         1170     1171       +1     
- Misses        564      566       +2     
- Partials       82       83       +1     
Impacted Files Coverage Δ
fitlins/cli/run.py 0.00% <0.00%> (ø)
fitlins/workflows/base.py 58.97% <33.33%> (-0.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 372e6d2...20045e3. Read the comment docs.

effigies commented 2 years ago

@Shotgunosine @adelavega What do you think? I'm not worried about the failing test. Seems one-off and other branches are passing.

Rendered version at https://fitlins--375.org.readthedocs.build/en/375/estimators.html

Shotgunosine commented 2 years ago

@effigies, looks good to me!

effigies commented 2 years ago

Thanks! And thanks for the first pass on this doc.