Added "color" as attribute to Billboard class.

poliastro / czml3

Python 3 library to write CZML

https://pypi.org/project/czml3/

MIT License

37 stars 30 forks source link

Added "color" as attribute to Billboard class. #106

Closed rengrub closed 1 year ago

rengrub commented 1 year ago

Not sure if "color" was omitted purposefully or by mistake from Billboard, or perhaps it was a recent addition to the CZML spec. I am proposing to add color as an attribute. I have tested this locally and it works as expected.

astrojuanlu commented 1 year ago

I don't think color is a recent addition, the corresponding wiki page was last updated in 2019: https://github.com/AnalyticalGraphicsInc/czml-writer/wiki/Billboard

We mostly were adding attributes gradually as we needed them. Also to encourage external contributions :)

Tests failing because MyPy is unhappy (as usual), but I'm going to go ahead and merge anyway. Thanks @rengrub!