search

poliastro / czml3

Python 3 library to write CZML
https://pypi.org/project/czml3/
MIT License
42 stars 33 forks source link

Add holes attribute to polygon #114

Closed Stoops-ML closed 6 months ago

Stoops-ML commented 7 months ago
Stoops-ML commented 7 months ago

@astrojuanlu any idea why the circleci quality check is failing?

astrojuanlu commented 6 months ago

Ugh, direct invokations of setup.py on the command line are deprecated and possibly broken... 

python setup.py check

Looks like we'll need to get the CI green first (worth doing so in a separate PR)

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.23%. Comparing base (0477d4a) to head (97a024b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #114 +/- ## ======================================= Coverage 99.22% 99.23% ======================================= Files 12 12 Lines 776 784 +8 ======================================= + Hits 770 778 +8 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Stoops-ML commented 6 months ago

This would close https://github.com/poliastro/czml3/issues/96

astrojuanlu commented 6 months ago

Will require editing some merge conflicts