poliastro / czml3

Python 3 library to write CZML
https://pypi.org/project/czml3/
MIT License
40 stars 33 forks source link

GitHub Actions Implementation #128

Closed Stoops-ML closed 3 months ago

Stoops-ML commented 3 months ago

CircleCI action(?) needs to be removed from the repo.

Also, GitHub actions fails on Code Coverage: Error: Codecov token not found. Please provide Codecov token with -t flag.

A v1.0.0 tag needs to be added too.

astrojuanlu commented 3 months ago

Removed CircleCI checks as required.

I don't see the GHA ones coming up here in the PR though.

About Codecov, I can have a look at it. It's been a while since I last used the service, it became somewhat flaky.

Stoops-ML commented 3 months ago

I’m happy to implement an alternative to Codecov if you’d like.

I need to make another commit to trigger the actions on pull request (currently they’re only triggered on pushes).

Stoops-ML commented 3 months ago

GitHub actions are now running! CircleCI still running though.

astrojuanlu commented 3 months ago

Stopped CircleCI builds.

Added CODECOV_TOKEN to the Actions secrets, Codecov now suggests

- name: Upload coverage reports to Codecov
  uses: codecov/codecov-action@v4.0.1
  with:
    token: ${{ secrets.CODECOV_TOKEN }}
Stoops-ML commented 3 months ago

Added CODECOV_TOKEN to the Actions secrets, Codecov now suggests

- name: Upload coverage reports to Codecov
  uses: codecov/codecov-action@v4.0.1
  with:
    token: ${{ secrets.CODECOV_TOKEN }}

That action is already in the workflow file (see here).

I will make another commit to update the Codecov action from v4 to v4.0.1.

Stoops-ML commented 3 months ago

CircleCI has indeed stopped. However, Codecov is still throwing the error Codecov token not found. See here for the Codecov configuration in the GitHub actions workflow file.

Did you follow the Codecov instructions here for adding the token?

If a quick work-around is desired, I can disable the fail_ci_if_error parameter for Codecov.

astrojuanlu commented 3 months ago

Did you follow the Codecov instructions here for adding the token?

I thought I had, but I had added it to my fork 🥲 Added it now, please try again.

astrojuanlu commented 3 months ago

Secrets "are not passed to workflows that are triggered by a pull request from a fork."

image

Also, from Codecov instructions:

Keep in mind that secrets are not available to forks of repositories.

https://github.com/codecov/codecov-action?tab=readme-ov-file#usage

So I guess everything is working as expected now.

astrojuanlu commented 3 months ago

I'm proceeding with the merge to see if the main branch is able to upload the Codecov report. But we'll have to figure out what to do in this case.

astrojuanlu commented 3 months ago

Error: No coverage reports found. Please make sure you're generating reports successfully. Error: Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4.5.0/dist/codecov' failed with exit code 1

Nope, broken

astrojuanlu commented 3 months ago

@Stoops-ML you have write access now, try creating a branch in this repo so that the coverage action works.