search

poliastro / czml3

Python 3 library to write CZML
https://pypi.org/project/czml3/
MIT License
42 stars 33 forks source link

feat: number and epoch types, IntervalValue list parsing #151

Closed vishwa2710 closed 4 months ago

vishwa2710 commented 4 months ago

@Stoops-ML done!

vishwa2710 commented 4 months ago

🤦 thanks! This should be good.

Stoops-ML commented 4 months ago

The test test_interval_value() failed because the class CustomValue is not a subclass of BaseCZMLObject.

vishwa2710 commented 4 months ago

Ah sorry for the mess. I wasn't running the tests locally as the setup is not containerized. I went through the motions and I've tested this locally. It should pass now 💯

vishwa2710 commented 4 months ago

Would we be opposed to containerizing this repo and adding a makefile with some simple commands for testing, formatting, etc.?

Stoops-ML commented 4 months ago

Need to run ruff format and ruff check --fix to format the code.

Stoops-ML commented 4 months ago

Would we be opposed to containerizing this repo and adding a makefile with some simple commands for testing, formatting, etc.?

Open an issue on this. I'd like to hear what others think about this.

vishwa2710 commented 4 months ago

Checked with ruff 👍