search

poliastro / czml3

Python 3 library to write CZML
https://pypi.org/project/czml3/
MIT License
38 stars 30 forks source link

add ViewFrom, fixup nit #74

Closed mhaberler closed 3 years ago

mhaberler commented 3 years ago

not sure I should run 'tox -e reformat' on this and commit it?

this is the changes it would cause: https://github.com/mhaberler/czml3/commit/2bb86cf3fd2f470ff5b01e717e1c8abc3f67fd8a

codecov-io commented 3 years ago

Codecov Report

Merging #74 (cf3be1d) into master (260deee) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   99.17%   99.19%   +0.01%     
==========================================
  Files          12       12              
  Lines         728      743      +15     
==========================================
+ Hits          722      737      +15     
  Misses          6        6
Impacted Files Coverage Δ
src/czml3/properties.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 260deee...cf3be1d. Read the comment docs.

mhaberler commented 3 years ago

halleluja. long live the learning curve!

astrojuanlu commented 3 years ago

Glad to see you got tox running @mhaberler , and thanks for this PR! Reviewing it right now :eyes:

astrojuanlu commented 3 years ago

Merged! :rocket:

mhaberler commented 3 years ago

had to move to Python 3.8 from 3.9 on OSX to get everything in sync. Thanks!