search

poliastro / poliastro

poliastro - :rocket: Astrodynamics in Python
https://docs.poliastro.space
MIT License
888 stars 285 forks source link

Interface infelicity: third_body() #938

Closed wumpus closed 4 years ago

wumpus commented 4 years ago

poliastro.core.perturbations has a method third_body that has a kw argument named third_body.

Think for a moment what that means when you try to wrap the function:

from poliastro.core.perturbations import third_body
def wrapper(**kwargs):
   foo = third_body(..., third_body)
jorgepiloto commented 4 years ago

Wow! Good catch @wumpus :rocket:

What about perturbation_body as function parameter? :thinking:

wumpus commented 4 years ago

That's a great name.

astrojuanlu commented 4 years ago

"infelicity" made me chuckle :) Agreed with @jorgepiloto suggestion

priyanshurohilla commented 4 years ago

I have fixed this issue. Just waiting for my previous PR #940 to merge and then i'll open a PR for this:)

priyanshurohilla commented 4 years ago

@astrojuanlu This can be closed now:)