search

poliastro / validation

Validation of poliastro against external software.
Apache License 2.0
11 stars 6 forks source link

Add automated quality checks #5

Closed astrojuanlu closed 3 years ago

astrojuanlu commented 3 years ago

It is unlikely that we will be able to run these tests on CI (or... perhaps not that unlikely?) but regardless, it would be nice to have automated quality checks about PEP8 (preferably flake8 + black).

jorgepiloto commented 3 years ago

What about Github actions? Tools like Miniconda or Anaconda are available, together with code-quality checkers.

These actions can be triggered for particular situations such us new commits in main branch, particular tags... We could start by exploring just the checkers for the moment and see how it performs :thinking:

astrojuanlu commented 3 years ago

Yeah, absolutely! GH Actions, Circle CI or Azure Pipelines are all equally valid from my side.

jorgepiloto commented 3 years ago

Before closing this: it is possible to trigger the Github actions when a new event takes place in the poliastro's repository (new release, merge into master...). See workflow-dispatch-events.

jorgepiloto commented 3 years ago

Ops! Closing this, as CI is already been triggered every time a PR is made or when poliastro merges new code into its main branch.