Closed jorgepiloto closed 3 years ago
Seems to be working properly. By the way, it needs a rebase :+1:
The flake8 tool suggests to remove the setup_orekit_curdir
from orekit_orbit.py
. However, if this line is removed, the pytest tests/
does not execute properly... This is weird because should be fixed by the custom setup_orekit_env
function in utils.py
:thinking:
Cool! The orekit/tests
are now being executed by the CI action. I will try to finish this tomorrow so it is finally ready for a review :rocket:
The flake8 tool suggests to remove the
setup_orekit_curdir
fromorekit_orbit.py
. However, if this line is removed, thepytest tests/
does not execute properly... This is weird because should be fixed by the customsetup_orekit_env
function inutils.py
thinking
It seems that orekit-data.zip
holds all the org.
routines. Hence, our custom function setup_orekit_env()
should be defined before all the org.orekit
and org.hipparchus
import statements.
Hoever, this new order makes flake8
to raise the E402
error, see:
E402 module level import not at top of file
How could we proceed, @astrojuanlu? Should we ignore this error in the ci_actions.yml
under the extra-flake8-options
variable?
⚠️ HISTORY HAS BEEN REWRITTEN ⚠️ This will need a rebase
About your comment above @jorgepiloto , I suggest we do this instead: https://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html#in-line-ignoring-errors
Sure! I did not know about ignoring inline errors :open_mouth:
Sorry for this mess with the quality checks. I am not sure why my local configuration does not match the one from the actions YAML file :sweat:
Merging this! All tests passing now :rocket:
Implements a CI GitHub action for code quality checking.