Updated DMC / SADA to match with ARC PLC

policy-design-lab / data-import

Programs used to convert raw CSV files into JSON files for various PDL programs

0 stars 0 forks source link

Updated DMC / SADA to match with ARC PLC #62

Closed ywkim312 closed 12 months ago

sandeep-ps commented 12 months ago

Please update the CHANGELOG. The rest looks good to me. Thanks.

ywkim312 commented 12 months ago

Please update the CHANGELOG. The rest looks good to me. Thanks.

the change log entry is already in there?

Dairy and Disaster data import program and generate JSON files. #59

It was just adding some information of the json only. If I need to create an issue and need to add changelog, then I will do

ywkim312 commented 12 months ago

Please update the CHANGELOG. The rest looks good to me. Thanks.

The reason why was because it was not released yet so just modified the json only to get the final approval

sandeep-ps commented 12 months ago

Hi, @ywkim312, on this PR, I do not see a CHANGELOG update.

You have linked #61 to this PR, right? Shouldn't that be added to the CHANGELOG?

ywkim312 commented 12 months ago

Hi, @ywkim312, on this PR, I do not see a CHANGELOG update.

You have linked #61 to this PR, right? Shouldn't that be added to the CHANGELOG?

Oh sorry, my explanation was bad. This PR doesn't have changelog it is because it was just update of json that was the part of not released issue in API part. So I wanted this to be the part of the DMC/SADA release instead of the separated issue. But since you insist, I will add it.

ywkim312 commented 12 months ago

changelog updated

sandeep-ps commented 12 months ago

changelog updated

Sorry, I don't think I fully understand what you explained. Thanks for updating the CHANGELOG of this repo as it's good for future reference. On a side note, we haven't started releasing this repo yet, but it's something that we need to consider in the near future. Thanks.

ywkim312 commented 12 months ago

changelog updated

Sorry, I don't think I fully understand what you explained. Thanks for updating the CHANGELOG of this repo as it's good for future reference. On a side note, we haven't started releasing this repo yet, but it's something that we need to consider in the near future. Thanks.

changelog updated

Sorry, I don't think I fully understand what you explained. Thanks for updating the CHANGELOG of this repo as it's good for future reference. On a side note, we haven't started releasing this repo yet, but it's something that we need to consider in the near future. Thanks.

Hmm sorry about my bad explanation. The release what I meant was the release of API. I thought I explained it above but maybe not? I have no idea of release this "data-import" repo. :)