policy-design-lab / data-import

Programs used to convert raw CSV files into JSON files for various PDL programs
0 stars 0 forks source link

Added missing fields to EQIP and CSP json #91

Closed ywkim312 closed 6 months ago

ywkim312 commented 6 months ago

Thank you, @ywkim312! This is exactly what I need for EQIP!

Regarding CSP, I have a quick question. I noticed that the totalPaymentInDollars and totalPaymentInPercentageNationwide are already available in the CSP state-distribution endpoint: https://policydesignlab-dev.ncsa.illinois.edu/pdl/titles/title-ii/programs/csp/state-distribution

Given that CSP seems to already have these two data points, will the changes proposed in this PR impact the CSP state-distribution? EQIP definitely requires these data points, but it appears that CSP already includes them.

I don't see those in csp? Can you check again?

ywkim312 commented 6 months ago

Thank you, @ywkim312! This is exactly what I need for EQIP!

Regarding CSP, I have a quick question. I noticed that the totalPaymentInDollars and totalPaymentInPercentageNationwide are already available in the CSP state-distribution endpoint: https://policydesignlab-dev.ncsa.illinois.edu/pdl/titles/title-ii/programs/csp/state-distribution

Given that CSP seems to already have these two data points, will the changes proposed in this PR impact the CSP state-distribution? EQIP definitely requires these data points, but it appears that CSP already includes them.

Oh I see what you mean. Let me check one more time

pengyin-shan commented 6 months ago

Ohhh never mind @ywkim312! I was checking https://policydesignlab-dev.ncsa.illinois.edu/pdl/titles/title-ii/programs/csp/state-distribution and misinterpret the ones inside statutes, where your added ones are out of statutes:

Screenshot 2024-02-14 at 10 37 28 AM
ywkim312 commented 6 months ago

Yes the thing in CSP is only statute total not the state totla

pengyin-shan commented 6 months ago

@ywkim312 please go ahead with both EQIP and CSP 👍. They both need totalPaymentInDollars and totalPaymentInPercentageNationwide for the whole state