policykit / policykit

Toolkit for building governance in your online community
http://policykit.org
MIT License
130 stars 24 forks source link

Allow bulk editing of members #620

Open antiantivirus opened 9 months ago

antiantivirus commented 9 months ago

Should be able to edit more than one members roles at a time. So for example you might want to change user1, user2 and user3 to the role of admin.

Is it possible to update the current user edit method to accept an array of user ids @leijie-wang ? To me this seems to make the most sense as they it will work for single and bulk editing, however if you have a better solution please post.

leijie-wang commented 9 months ago

I added a few code to support this, but i am wondering which branch i should merge with?

antiantivirus commented 9 months ago

If push/merge into the new-frontend-members branch. Have associated that branch with this issue now.

antiantivirus commented 9 months ago

I was thinking if a user can have multiple roles then would it also make sense to be able to allow a user to assign or revoke multiple roles too?

So for example you want to assign 5 users the role of admin and special roles x then you would currently have to perform 2 submissions (one for each role you want assign). If we allow users to assign multiple roles to multiple users this could be performed in only 1 submission.

So roles would an array of roles like users.

leijie-wang commented 8 months ago

I am a little bit worried that this might be confusing to users sometimes, for example, when one of the users does not have one of the revoked roles. I also think cases where users need to assign multiple roles to multiple users might be quite infrequent?

antiantivirus commented 8 months ago

Ok let's leave it at assigning or revoking one role for multiple users as I agree with your point above.