polimediaupv / paella-core

Paella Player core library
Educational Community License v2.0
20 stars 15 forks source link

Request export PaellaCoreVideoFormats from paella-core #327

Closed karendolan closed 12 months ago

karendolan commented 1 year ago

Request for PaellaCoreVideoFormats to be added to the paella-core exports so new custom video plugins can be created by adopters. https://github.com/polimediaupv/paella-core/blob/main/src/index.js

polimediaupv commented 12 months ago

This is already being done. See the documentation for more information:

https://paellaplayer.upv.es/#/doc/exported_plugins.md

ferserc1 commented 12 months ago

A clarification: the classes that are currently exported correspond to the implementation of the video format. The video plugin classes were not being exported because their implementation is trivial.

However, I have added these classes as well, plus some utility functions. The documentation is already updated, and the changes with the new classes will be available in paella-core 1.44.

karendolan commented 12 months ago

The actual reason I asked for this because I'm temporarily overriding mp4Video and hlsVideo to workaround #323. Those files needed to links their imports. I ended up writing a temporary local file for that import.