Design: Move "Switch the video layout" from "Settings" to "View" button/menu

polimediaupv / paella-ethz

Educational Community License v2.0

1 stars 2 forks source link

Design: Move "Switch the video layout" from "Settings" to "View" button/menu #17

Closed oas777 closed 1 year ago

oas777 commented 1 year ago

Lisa suggested the new "View" button to host both the "video layout" and the "enable/disable slide preview", cf. https://tinyurl.com/2gox7lms. "Settings" should be for "Keyboard shortcuts" and maybe "Video quality".

miesgre commented 1 year ago

@oas777 We updated the player. Can you test the buttons are where it should be? Demo: https://polimediaupv.github.io/paella-ethz/?id=belmar-multiresolution-remote

oas777 commented 1 year ago

Not exactly what Lisa had in mind (she has "video layout" and "slides preview" both in the "view" button), but I can live with this.

oas777 commented 1 year ago

miesgre commented 1 year ago

slide preview and video layout are different things. I think it is not correct to join both concepts.

Video layout: Used to change the layout used.
Slide preview: shows you the slide previews and allows you to jump to one slide.

Check: https://polimediaupv.github.io/paella-ethz/?id=belmar_16_9_hls Captura de pantalla 2023-04-18 a las 14 40 16

Slide preview: Captura de pantalla 2023-04-18 a las 14 40 37

Video layout (images will be changes to text): Captura de pantalla 2023-04-18 a las 14 41 15 (we can even remove this button, since this functionality can be achieved with the buttons shown in the video)

@oas777 Maybe we can ask Lisa what she thinks about this?

oas777 commented 1 year ago

No need to ask Lisa: I didn't realise you were giving "video layout" a symbol of its own instead of putting it in "Settings" (which is good). The symbol for "slide preview" works for me.