search

polina4096 / resquake

Rewrite of a popular mod which brings quake-style movement to minecraft for Fabric mod loader in Kotlin
The Unlicense
26 stars 7 forks source link

Support for Ad Astra gravity #13

Closed NolanHewitt closed 3 months ago

NolanHewitt commented 9 months ago

Currently while using this mod the custom gravity on ad astra planets breaks and reverts to normal gravity. Is there any way this mod could be updated to work with other mods that have varying gravity values? If not, could there be a way to disable resquake movement only while in certain custom dimensions?

polina4096 commented 8 months ago

sure, i'll look into it

NolanHewitt commented 8 months ago

Thank you, I appreciate your work on continuing this mod. Even if the solution just has to be a way to blacklist certain dimensions, that would be ok. After all, it would make some sense that steve wouldn’t be able to make the crazy movements he makes with this mod on a place with gravity as different as the moon. Though it would be interesting to see what was possible with both quake movement and moon gravity haha.

NolanHewitt commented 8 months ago

I've also noticed the same thing happens with the mod Eden Ring. Its custom gravity effects don't work with this mod, but do when you use the hotkey to disable quake movement.

polina4096 commented 7 months ago

While it is technically possible to add support for every mod, both Ad Astra and Elden Ring Mod mixin into travel, which is exactly the how this mod works and why they are incompatible.

In case of the Elden Ring Mod it modifies the gravitational constant in the LivingEntity's travel. I can hardcode a fix, but a better solution would of course be to open an issue on the Elden Ring Mod repo and discuss better solutions there.

As for Ad Astra, they inject their movement code at the start of travel which is completely incompatible with how my mod works. I think that the best approach for me is to use the Ad Astra Gravity API and incorporate support for it into my mod.

NolanHewitt commented 7 months ago

Thank you for the update! Does botania do something similar for movement speed for its items that stop working with this mod active, a mixin for travel?