political-memory / political_memory

WARNING: this repository has now moved to https://git.laquadrature.net/memopol/memopol
https://memopol.lqdn.fr/
12 stars 2 forks source link

Fix favicon 404 and enhance to mobile support #144

Closed landrok closed 8 years ago

landrok commented 8 years ago
jpic commented 8 years ago

Nice !

Instead of adding the STATIC_ICONS_URL setting, could we just use the {% static %} template tag from django ?

https://docs.djangoproject.com/en/1.10/howto/static-files/ http://blog.yourlabs.org/post/30382323418/surviving-djangocontribstaticfiles-or-how-to

landrok commented 8 years ago

That's ok with https://github.com/political-memory/political_memory/pull/144/commits/d38c9837022c3dc487bd052a81a2514a333ec5d7, thanks for this advise, I'm (really) not a django expert.

Other thing, I saw there is a more recent branch, called "V3", maybe I should update this one too ?

njoyard commented 8 years ago

@landrok, thanks for the contribution. Indeed, you should work on v3 branch. This branch will disappear soon ;)

landrok commented 8 years ago

The branch has been removed, the patch is no longer relevant.