political-memory / political_memory

WARNING: this repository has now moved to https://git.laquadrature.net/memopol/memopol
https://memopol.lqdn.fr/
12 stars 2 forks source link

Force uses of django 1.8 in setup.py #150

Open okhin opened 8 years ago

okhin commented 8 years ago

In setup.py, the definition for the django requirement leads setup.py to do this:

Searching for django>=1.8,<1.9 Reading https://pypi.python.org/simple/django/ Best match: Django 1.9rc1

Indeed, 1.9rc1 is prior 1.9, and basically, memopol does not works on django1.9 :)

So, maybe enforcing django==1.8 in the setup.py will help

njoyard commented 8 years ago

Actually if you use pip to install it behaves correctly. I don't really know who's correct here. Semver is not very verbose on the subject ; it's clear for me that 1.9-rc1 is prior to 1.9, but if you request <1.9 you should not get 1.9-rc1. Anyway the docs tell to use pip, that's how you get known behaviour ;)

memopol-ci commented 8 years ago

Perhaps it's a bug in pip ?​

njoyard commented 8 years ago

Most likely a bug in setuptools rather, pip behaves as expected.