politico / vue-accessible-selects

Select & Multi Select implementations for Vue, focused especially on implementing accessibility best practices
https://vue-accessible-selects.netlify.app/
MIT License
13 stars 6 forks source link

key down navigation is not scrolling in view if list is overflowing #74

Open Felixclement opened 3 years ago

Felixclement commented 3 years ago

When using arrows to select options that are overflowing the menu does not scroll into view of the current option

jackkoppa commented 3 years ago

Great call, @Felixclement - we'll discuss & hopefully get this worked on. We've already got listeners for keyboard events, obviously, so perhaps there's a "simple" addition of maintaining scroll visibility if the key is an up or down navigation

jackkoppa commented 3 years ago

e.g. here https://github.com/politico/vue-accessible-selects/blob/main/src/SelectMulti.vue#L205-L207

jackkoppa commented 3 years ago

Hey @Felixclement, this is fixed w/ #82 & v0.13.1 - mind trying it out??