search

politics-rewired / Spoke

Politics Rewired's fork of Spoke
GNU General Public License v3.0
36 stars 17 forks source link

Distinguish 10DLC messaging service state for registration warning #1632

Closed ajohn25 closed 1 year ago

ajohn25 commented 1 year ago

Is your feature request related to a problem? Please describe. The current 10DLC registration warning is displayed based on whether a registered campaign is available in Spoke Portal. However, during the period between campaign registration and DCA vetting completion, users may believe they are sending on 10DLC when their registration is not yet ready.

Describe the solution you'd like Distinguish 3 states for the warning, which match the status of a registered profile for the organization (or at least would match the ideal profile status noted in this TODO):

  1. Brand Not Found - a registered brand for the organization is not found via the current Portal API query.
  2. Campaign Not Found - a registered brand for the organization is found via the current Portal API query, but a registered campaign is not.
  3. Pending - a registered campaign for the organization is found via the current Portal API query, but a registered profile has not yet been added to Spoke. This requires exposing the channel for switchboard profiles via a new Portal API query.
  4. Complete - a registered profile has been added to Spoke. This requires exposing the channel for switchboard profiles via a new Portal API query.

Describe alternatives you've considered Punt on changes to this warning in favor of better support through Portal's upcoming registration dashboard.

Additional context The proposed solution also provides a more useful warning for clients who manage their own 10DLC registrations.

ajohn25 commented 1 year ago

@bchrobot @hiemanshu lmk what you think of this? down to work on this next sprint if it sounds good!

bchrobot commented 1 year ago

I think this depends on the timeline for implementing the 10DLC management designs Kenny has been working on. If that won't be for a few weeks then this sounds like a good stopgap.

ajohn25 commented 1 year ago

@politics-rewired/spoke-client @kennyycheng lmk if this sounds good! i can also find a good icon for the notifications that don't have one, but wanted to get copy up for review

Brand Not Found (current warning image

Campaign Not Found image

Pending image

Complete image

ajohn25 commented 1 year ago

I think this depends on the timeline for implementing the 10DLC management designs Kenny has been working on. If that won't be for a few weeks then this sounds like a good stopgap.

carrying over from sprint planning we decided this should happen sooner