poljar / weechat-matrix

Weechat Matrix protocol script written in python
Other
957 stars 119 forks source link

stderr: Error with command 'matrix_sso_helper' #263

Open Hackerpcs opened 3 years ago

Hackerpcs commented 3 years ago

I seem to be getting this error constantly every 5 minutes and I'm not logged in, if I try to join a channel it says "stdout/stderr (matrix): raise LocalProtocolError("Not logged in.")".

My matrix.server.matrix_org.address is "matrix.org". matrix_sso_helper.py is on $PATH, also tried softlinking it without the .py extension if that maybe was the problem. Till today I didn't use SSO, just username+password. Weechat is latest 3.0 (20 Dec 2020), pip requirements are from arch's repo

pacman -S libolm python-pyopenssl python-typing_extensions python-webcolors python-future python-atomicwrites python-attrs python-logbook python-pygments python-matrix-nio python-aiohttp python-magic python-requests

and weechat-matrix is softlinked from latest pulled git.

Using element.io shows that the last login from weechat was on Februray 18, it seems that around that time something broke.

matthijskooijman commented 3 years ago

I'm seeing this same message today after restarting weechat. Everything was working fine before the restart, now login seems to fail with this message, followed by "stderr: Error with command 'matrix_sso_helper'" after 7 minutes and reconnect with the same thing. Not sure if this is exactly the same problem as from the original post, but might be.

i.e.:

19:23 -- matrix: Connecting to matrix.org:443 (SSL)...
19:23 -- matrix: Doing SSL handshake...
19:23 -- matrix: Connected using TLSv1.3, and 256 bit TLS_AES_256_GCM_SHA384 cipher suite.
19:23 -- matrix: received certificate
19:23  - certificate info:
19:23     - subject: commonName=www.matrix.org, serial number
19:23         0480EFA9D83BA33254B0925C36CF7E393C4C
19:23     - issuer: countryName=US, organizationName=Let's Encrypt,
19:23         commonName=R3
19:23     - key info: RSA key 4096 bits, signed using
19:23         sha256WithRSAEncryption
19:23     - period of validity:
19:23         Begins on:  Feb  6 02:08:23 2021 GMT
19:23         Expires on: May  7 02:08:23 2021 GMT
19:23     - fingerprints:
19:23         SHA1:   EE:A2:F7:16:9F:7A:9D:87:E2:1A:89:BC:C6:88:92:F8:B1:25:16:15
19:23         SHA256: 61:84:80:45:DE:42:21:96:BB:BA:23:23:5C:D3:08:CC:72:BC:77:35:36:91:46:31:68:4E:3D:D7:7D:1F:55:D0
19:23 stderr: Error with command 'matrix_sso_helper'
19:30 -- matrix: Error while reading from socket
19:30 -- matrix: disconnecting from server...
19:30 -- matrix: disconnected from server
19:30 -- matrix: reconnecting to server in 10 seconds
19:30 -- matrix: reconnecting to server...
19:30 -- matrix: Connecting to matrix.org:443 (SSL)...
matthijskooijman commented 3 years ago

I just updated to the latest master (was previously running 69ad2a9c03d516c212d3d0700dbb2bfe654f6365) and the problem went away. I tested 69ad2a9c03d516c212d3d0700dbb2bfe654f6365 again (to rule out that a simple reload fixed it) and that was still broken, so I guess the issue I was seeing has been fixed since. I'm now running ef09292005d67708511a44c8285df1342ab66bd1 without login issues.

I actually suspect that ef09292005d67708511a44c8285df1342ab66bd1 fixed this (or at leasts hides the problem), which prevents triggering the SSO flow when a username and password is configured.

Hackerpcs commented 3 years ago

I just pulled latest ef09292 and it still appears

ChuckNorrison commented 3 years ago

I received this error after /unsetuser and password and try to /connect

seanmorris commented 3 years ago

Getting this error on a fresh install via apt-get. Is this not expected to be usable just yet? The billing on the matrix site seems to present it as production-ready...

2knarf commented 3 years ago

Also happening on Gentoo

ChuckNorrison commented 3 years ago

Try to setup your account first, than /connect

roygbyte commented 3 years ago

@ChuckNorrison Correct me if I'm wrong, but isn't it not possible to setup an account first? If an account is using SSO, then it only has a username associated with a server and not a password. At least, that's how it looks for me.

I have signed up for an account via Element.io using Github SSO. I have then followed the steps outlined in this repo for SSO and received the aforementioned error.

For the folks who seem to have no trouble: how have you setup your account? Do you /set the username?

matthijskooijman commented 3 years ago

For the folks who seem to have no trouble: how have you setup your account? Do you /set the username?

Things are working for me for quite a while (though I did get this error with an older version). I'm not using SSO/social logins, but looking at my configuration, it seems I have configured my username and password in weechat-matrix directly.

strk commented 1 year ago

The error was fixed for me by making the matrix_sso_helper command available (without the .py extension) in PATH. Ie: cp matrix_sso_helper.py /usr/local/bin/matrix_sso_helper; chmod +x /usr/local/bin/matrix_sso_helper

Next issue is that matrix.org (but not other homeservers) REQUIRES sso signin.. See #311