search

polkadot-cloud / polkadot-developer-console

A Next-Generation Polkadot Developer Console.
https://console.polkadot.cloud
GNU Affero General Public License v3.0
7 stars 1 forks source link

feat: Reconnect to Wallet Connect session on signing #251

Closed rossbulat closed 3 weeks ago

rossbulat commented 3 weeks ago

Reconnects to a WC session when signing a transaction if needed, and checks if the signer address is a part of the WC session.

Summary by CodeRabbit

Release Notes

These updates enhance user experience by streamlining account retrieval and improving session management.

coderabbitai[bot] commented 3 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new method fetchAccounts to the WalletConnect context and related components, enhancing account retrieval functionality based on a specified chain ID. This method is added to the defaultWalletConnect object and the WalletConnectContextInterface. The ManageWalletConnect component is updated to utilize this new method, simplifying account management by removing session initialization logic. Additionally, several z-index values in the modal components are adjusted for better layering. Overall, the changes focus on improving the WalletConnect integration and account handling.

Changes

File Path Change Summary
packages/app/src/contexts/WalletConnect/defaults.ts Added method fetchAccounts(directoryId) to defaultWalletConnect, returning a resolved promise with an empty array.
packages/app/src/contexts/WalletConnect/index.tsx Introduced fetchAccounts(chainid: ChainId): Promise<string[]>, updated context provider to include this method.
packages/app/src/contexts/WalletConnect/types.ts Added method signature fetchAccounts(directoryId: ChainId) => Promise<string[]> to WalletConnectContextInterface.
packages/app/src/library/ConnectOverlay/ManageWalletConnect.tsx Added fetchAccounts to the useWalletConnect hook, simplified handleImportAddresses to directly call fetchAccounts.
packages/app/src/library/Overlay/index.scss Adjusted z-index values for modal components, reducing values for several classes.
packages/app/src/library/SubmitTx/ManualSign/WalletConnect/index.tsx Updated useWalletConnect to destructure fetchAccounts, enhanced transaction signing logic with account validation.

Possibly related PRs

🐇 In the meadow, hopping around,
A new method's here, accounts to be found!
With fetchAccounts, we simplify the way,
No more sessions to manage, hip-hip-hooray!
So let’s connect and sign with glee,
A smoother journey, just wait and see! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.