Closed patrickgparity closed 1 year ago
@patrickgparity This "group toggle-pills together" component feels like single selection tab to me: Where I can only view Active OR Locked OR Destroy.
This still satisfies core case of "defaulting to active only on landing" and I do not think I mind the isolated views for Locked OR Destroy. Is this the intent for interaction?
I would have saved you a lot of time here if I was consulted on this. I strongly disagree on the assumptions that the filters are cognitive overload - they are fine as they are and people will know how to use them.
I also think "include active validators" is a lot more intuitive than "exclude inactive validators". The reason I am excluding all others is because I want to include only the active ones.
Yes, they can be further abstracted / simplified, and this is known, but I did not not jump into a second abstraction so soon after this base one since it is an entirely refreshed system at play, and designing a second abstraction over this base takes time and involves entirely new components that may not be generic across all lists. Further abstractions require the concept of inclusions and exclusions; the logic in place now lays the groundwork for more intelligent filters that can combine them.
The filter context & logic in place now was intentionally designed to be the base layer and generic across all lists that need filtering. the overlays offer an instant way to summon filters that could be infinitely expanded without interfering with the main interface. This is good UX that works across all form factors, and will be fine until I have time to iterate the filter system.
@rossbulat The "Filters" itself are fine. I would agree that there is room to improve UX. I am not clear on priority or challenges.
From my view, we could use to set two types of workflows:
(1) Bugs / Typos / Etc... - Just drop into Github - I think we are good here. (2) Proposals / Recommendations on UX - We could use the fastest, most efficient path for vetting ideas and proposals in/out so we can spend time on working on what needs to be done. There's a few ways I can see that working for a remote team.
My understanding from our chat was that proposal discussions (like this) should happen in Github so I pointed @patrickgparity here for that review. If we can save time using another workflow, method, venue - let's do that.
Need to switch gears and pull data for rest of the day. We can connect at the next convenience.
Current UI in Discussion URL: Here (click All pools tab)
Problem:
Solution:
Updated with proposed changes: