polkadot-fellows / RFCs

Proposals for change to standards administered by the Fellowship.
https://polkadot-fellows.github.io/RFCs/
Creative Commons Zero v1.0 Universal
111 stars 51 forks source link

Introduce System version to RuntimeVersion object #42

Closed vedhavyas closed 5 months ago

vedhavyas commented 9 months ago

This RFC proposes adding system_version and remove state_version from RuntimeVersion object. This makes it possible to use StateVersion::V1 for both Storage and Extrinsic root derivations

vedhavyas commented 8 months ago

Would be really helpful if we can get some more feedback on this one from other team members :)

vedhavyas commented 8 months ago

@bkchr @tomaka The RFC is updated as per our discussion above. Please let me know your feedback

tomaka commented 8 months ago

The Motivation section is not super clear. Another motivation is https://github.com/polkadot-fellows/RFCs/issues/19. But I would vote yes.

vedhavyas commented 8 months ago

The Motivation section is not super clear.

This is the only use case we have right now. Is the wording confusing or does not meet standards?

Another motivation is https://github.com/polkadot-fellows/RFCs/issues/19.

I can tag this in the motivation section if it helps

tomaka commented 8 months ago

I just mean that someone who isn't deeply familiar with the trie format and V0 and V1 will not understand the "Motivation" section. But that's not a big deal to me.

vedhavyas commented 7 months ago

@tomaka what would be the next steps here ? I can submit a change set to polkadot-sdk as well. Please let me know

nazar-pc commented 6 months ago

Any blockers for moving forward with this?

ggwpez commented 6 months ago

Any blockers for moving forward with this?

"Just" needs some approvals 😄

tomaka commented 6 months ago

Looks good to me.

tomaka commented 6 months ago

If there's no other comment, I can submit your RFC for voting.

vedhavyas commented 6 months ago

No other changes from my end. Thank you!!

tomaka commented 5 months ago

/rfc propose

paritytech-rfc-bot[bot] commented 5 months ago

Hey @tomaka, here is a link you can use to create the referendum aiming to approve this RFC number 0042.

Instructions 1. Open the [link](https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fpolkadot-collectives-rpc.polkadot.io#/extrinsics/decode/0x3d003e02015901000049015246435f415050524f564528303034322c64653665663539653334613965396338373464653635666230313732346137656539653134616334646339303764333834393730333436613863616231326130290100000000). 2. Switch to the `Submission` tab. 3. Adjust the transaction if needed (for example, the proposal Origin). 4. Submit the Transaction

It is based on commit hash 36b9812834179d8d5109e6ca064a38197d8557d0.

The proposed remark text is: RFC_APPROVE(0042,de6ef59e34a9e9c874de65fb01724a7ee9e14ac4dc907d384970346a8cab12a0).

tomaka commented 5 months ago

Proposed: https://collectives.polkassembly.io/referenda/70

github-actions[bot] commented 5 months ago

Voting for this referenda is ongoing.

Vote for it [here]https://collectives.polkassembly.io/referenda/70

tomaka commented 5 months ago

/rfc process 0x10ac786bc859fbaad56ca436bd822a01e0f120d37f85680621700323d35756d9

paritytech-rfc-bot[bot] commented 5 months ago

Unable to find the referendum confirm event in the given block.

Instructions to find the block hashHere is one way to find the corresponding block hash. 1. Open the referendum on Subsquare. 2. Switch to the `Timeline` tab. --- 3. Go to the details of the `Confirmed` event. --- 2. Go to the details of the block containing that event. --- 2. Here you can find the block hash.
tomaka commented 5 months ago

/rfc process 0x2cd018900d9c915ce8104cc6e37141b663cb46d13aadbff9dbfa038211228789

paritytech-rfc-bot[bot] commented 5 months ago

The on-chain referendum has approved the RFC.

vedhavyas commented 5 months ago

@tomaka Can you explain what is the process next? I would be happy to produce a PR for this RFC

bkchr commented 5 months ago

@vedhavyas feel free to open a pr and link to the RFC in the pr description. Thank you!