1.2.0 Release - Githubissues

bkontur commented 10 months ago

Please everyone leave a comment with a link to a pr or issue, so we have it tracked.

TODO

[x] PR with bump to polkadot@1.5 https://github.com/polkadot-fellows/runtimes/pull/137 (minimal configurations, just to compile)
[x] PR with bump to polkadot-sdk@1.6.0 https://github.com/polkadot-fellows/runtimes/pull/159
[x] PR with bump to polkadot-sdk@1.7.0 https://github.com/polkadot-fellows/runtimes/pull/187
[x] check/fix migrations when 1.1.0 / 1.1.2 deployed https://github.com/polkadot-fellows/runtimes/pull/195
[x] regenerate weights
- [x] regenerate weights for all pallets https://github.com/polkadot-fellows/runtimes/pull/223
- [x] ping https://github.com/polkadot-fellows/runtimes/pull/187#issuecomment-1969253891
- [x] check bridge transfer fee constants
[x] bump spec_versions to 1_002_000 - done in https://github.com/polkadot-fellows/runtimes/pull/187
[x] check and bump transaction versions https://github.com/polkadot-fellows/runtimes/issues/250
[x] check Nacho's integration tests
- [x] check/verify e2e tests: OpenGov -> relay to AssetHub - see comment @muharem
[x] fix #[api_version(7)] impl primitives::runtime_api::ParachainHost - fn node_features + verify what is missing https://github.com/polkadot-fellows/runtimes/pull/194
[x] add benchmark cumulus_pallet_parachain_system to SP runtimes
[x] address comment here

[x] integration tests improvement - adapt comment fixed by https://github.com/polkadot-fellows/runtimes/pull/185

# TODO: replace with `emulated-integration-tests-common@X.Y.Z` from `polkadot-sdk`
integration-tests-common = { path = "../common" }

[x] remove unneeded dependencies (cargo machete)
[x] fix pallet_asset_conversion benchmarks https://github.com/paritytech/polkadot-sdk/issues/3440
[x] Adds Snowbridge to Kusama and Polkadot Runtimes https://github.com/polkadot-fellows/runtimes/pull/130

alexggh commented 7 months ago

[x] Bump pallet-authorithy-discovery to include https://github.com/paritytech/polkadot-sdk/pull/3733

bkontur commented 7 months ago

[x] https://github.com/polkadot-fellows/runtimes/pull/245

bkontur commented 7 months ago

1.2.0 is almost ready, missing just:

From description:

[x] check and bump transaction versions https://github.com/polkadot-fellows/runtimes/issues/250
[x] check Nacho's integration tests
- [x] check/verify e2e tests: OpenGov -> relay to AssetHub - see comment @muharem

From comments:

eskimor commented 7 months ago

All of them look pretty ready! Let's get this done today! :rocket:

acatangiu commented 7 months ago

https://github.com/polkadot-fellows/runtimes/pull/245 needs rank3+ approval because it touched CI file

eskimor commented 7 months ago

https://github.com/polkadot-fellows/runtimes/pull/245 needs rank3+ approval because it touched CI file

My approval still does not count. Anybody knows why?

bkchr commented 7 months ago

My approval still does not count. Anybody knows why?

It did, please be patient with the CI :P

bkchr commented 7 months ago

check Nacho's integration tests

* [ ]  check/verify e2e tests: OpenGov -> relay to AssetHub - see [comment](https://github.com/polkadot-fellows/runtimes/pull/187/files#r1507284250) @muharem

@bkontur what is up with this?

NachoPal commented 7 months ago

Tests are green, but I had to comment init_state_migration::InitMigrate because I was getting the below error when trying to run Polkadot's runtime upgrade with Chopsticks. It is probably an issue with smoldot.

runtime::state-trie-migration DEBUG: [19993546] 🤖 running migrations on top of MigrationTask { top: To start, child: To start, dyn_top_items: 0, dyn_child_items: 0, dyn_size: 0, size: 0, top_items: 0, child_items: 0 } until MigrationLimits { size: 409600, item: 4800 }
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([], 512))
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([5, 149, 38, 117, 134, 181, 119, 68, 146, 120, 132, 245, 25, 235, 129, 1, 78, 123, 144, 18, 9, 107, 65, 196, 235, 58, 175, 148, 127, 110, 164, 41], 512))
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([6, 222, 61, 138, 84, 210, 126, 68, 169, 213, 206, 24, 150, 24, 242, 45, 78, 123, 144, 18, 9, 107, 65, 196, 235, 58, 175, 148, 127, 110, 164, 41], 512))
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([6, 222, 61, 138, 84, 210, 126, 68, 169, 213, 206, 24, 150, 24, 242, 45, 83, 180, 18, 59, 46, 24, 110, 7, 251, 123, 173, 93, 218, 95, 85, 192], 512))
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([6, 222, 61, 138, 84, 210, 126, 68, 169, 213, 206, 24, 150, 24, 242, 45, 180, 180, 157, 149, 50, 13, 144, 33, 153, 76, 133, 15, 37, 184, 227, 133], 512))
panicked at /Users/nacho/Desktop/PARITY/Repos/chopsticks/vendor/smoldot/lib/src/executor/storage_diff.rs:207:13:
assertion failed: in_parent_next_key > key

Stack:

Error
    at imports.wbg.__wbg_new_abda76e883ba8a5f (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:801:19)
    at wasm://wasm/00b1e282:wasm-function[1108]:0x191195
    at wasm://wasm/00b1e282:wasm-function[1334]:0x19979c
    at wasm://wasm/00b1e282:wasm-function[1318]:0x1992e0
    at wasm://wasm/00b1e282:wasm-function[245]:0x10b484
    at wasm://wasm/00b1e282:wasm-function[115]:0xba794
    at wasm://wasm/00b1e282:wasm-function[632]:0x16b359
    at wasm://wasm/00b1e282:wasm-function[1476]:0x19aeb1
    at __wbg_adapter_48 (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:384:10)
    at real (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:366:22)

node:internal/event_target:1096
  process.nextTick(() => { throw err; });
                           ^
Error [RuntimeError]: unreachable
    at wasm://wasm/00b1e282:wasm-function[1108]:0x1912ab
    at wasm://wasm/00b1e282:wasm-function[1334]:0x19979c
    at wasm://wasm/00b1e282:wasm-function[1318]:0x1992e0
    at wasm://wasm/00b1e282:wasm-function[245]:0x10b484
    at wasm://wasm/00b1e282:wasm-function[115]:0xba794
    at wasm://wasm/00b1e282:wasm-function[632]:0x16b359
    at wasm://wasm/00b1e282:wasm-function[1476]:0x19aeb1
    at __wbg_adapter_48 (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:384:10)
    at real (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:366:22)
    at node:internal/process/task_queues:140:7

bkchr commented 7 months ago

It is probably an issue with smoldot.

Yeah looks like one.

bkontur commented 7 months ago

Tests are green, but I had to comment init_state_migration::InitMigrate because I was getting the below error when trying to run Polkadot's runtime upgrade with Chopsticks. It is probably an issue with smoldot.

runtime::state-trie-migration DEBUG: [19993546] 🤖 running migrations on top of MigrationTask { top: To start, child: To start, dyn_top_items: 0, dyn_child_items: 0, dyn_size: 0, size: 0, top_items: 0, child_items: 0 } until MigrationLimits { size: 409600, item: 4800 }
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([], 512))
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([5, 149, 38, 117, 134, 181, 119, 68, 146, 120, 132, 245, 25, 235, 129, 1, 78, 123, 144, 18, 9, 107, 65, 196, 235, 58, 175, 148, 127, 110, 164, 41], 512))
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([6, 222, 61, 138, 84, 210, 126, 68, 169, 213, 206, 24, 150, 24, 242, 45, 78, 123, 144, 18, 9, 107, 65, 196, 235, 58, 175, 148, 127, 110, 164, 41], 512))
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([6, 222, 61, 138, 84, 210, 126, 68, 169, 213, 206, 24, 150, 24, 242, 45, 83, 180, 18, 59, 46, 24, 110, 7, 251, 123, 173, 93, 218, 95, 85, 192], 512))
runtime::state-trie-migration TRACE: [19993546] 🤖 migrated a top key, next_top_key = Some(BoundedVec([6, 222, 61, 138, 84, 210, 126, 68, 169, 213, 206, 24, 150, 24, 242, 45, 180, 180, 157, 149, 50, 13, 144, 33, 153, 76, 133, 15, 37, 184, 227, 133], 512))
panicked at /Users/nacho/Desktop/PARITY/Repos/chopsticks/vendor/smoldot/lib/src/executor/storage_diff.rs:207:13:
assertion failed: in_parent_next_key > key

Stack:

Error
    at imports.wbg.__wbg_new_abda76e883ba8a5f (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:801:19)
    at wasm://wasm/00b1e282:wasm-function[1108]:0x191195
    at wasm://wasm/00b1e282:wasm-function[1334]:0x19979c
    at wasm://wasm/00b1e282:wasm-function[1318]:0x1992e0
    at wasm://wasm/00b1e282:wasm-function[245]:0x10b484
    at wasm://wasm/00b1e282:wasm-function[115]:0xba794
    at wasm://wasm/00b1e282:wasm-function[632]:0x16b359
    at wasm://wasm/00b1e282:wasm-function[1476]:0x19aeb1
    at __wbg_adapter_48 (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:384:10)
    at real (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:366:22)

node:internal/event_target:1096
  process.nextTick(() => { throw err; });
                           ^
Error [RuntimeError]: unreachable
    at wasm://wasm/00b1e282:wasm-function[1108]:0x1912ab
    at wasm://wasm/00b1e282:wasm-function[1334]:0x19979c
    at wasm://wasm/00b1e282:wasm-function[1318]:0x1992e0
    at wasm://wasm/00b1e282:wasm-function[245]:0x10b484
    at wasm://wasm/00b1e282:wasm-function[115]:0xba794
    at wasm://wasm/00b1e282:wasm-function[632]:0x16b359
    at wasm://wasm/00b1e282:wasm-function[1476]:0x19aeb1
    at __wbg_adapter_48 (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:384:10)
    at real (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/executor/dist/esm/chopsticks_executor.js:366:22)
    at node:internal/process/task_queues:140:7

@muharem @NachoPal so, can we consider these two points as done, or is anything missing?

[x] check Nacho's integration tests
- [x] check/verify e2e tests: OpenGov -> relay to AssetHub - see comment @muharem

NachoPal commented 7 months ago

we consider these two points as done

Yes, you can check the box

kianenigma commented 7 months ago

[ ] we need to make sure that pallet-staking version 29.0.1 is released and used, which is the current version plus https://github.com/paritytech/polkadot-sdk/pull/3639 and (potentially one other patch). This is basically making sure that the bug we fixed in 1.1.3 runtime release won't re-appear. Being worked on by @gpestana.

bkontur commented 7 months ago

[ ] we need to make sure that pallet-staking version 29.0.1 is released and used, which is the current version plus Staking ledger bonding fixes paritytech/polkadot-sdk#3639 and (potentially one other patch). This is basically making sure that the bug we fixed in 1.1.3 runtime release won't re-appear. Being worked on by @gpestana.

So, it looks like everything is marked as done, and this is the last thing.

One question or point: do we want to regenerate fresh weights once more?

I did it for all runtimes here based on main branch commit f5aeb7e8cc024a17a42ca547645f25f2ae28e4f4 commit and after that I also did fresh weights for people-kusama / coretime-kusama and Snowbridge pallets.

I'm just bringing this to your attention because last time it took somewhere between 12 to 23 hours on Oliver's machine (Kusama/Polkadot are the slowest - several hours, while SPs are fast). Maybe there's no need to regenerate for all runtimes, and we could just regenerate for the concrete pallets affected after commit f5aeb7e8cc024a17a42ca547645f25f2ae28e4f4?

I can see just these candidates:

pallet_state_trie_migration
pallet_asset_conversion
pallet_treasury
pallet_staking

E.g. is this ok? https://github.com/polkadot-fellows/runtimes/commit/360581ffedd048262177ddc135d66cec455b959a#diff-e7afb81f3cef77f8a1686085f1adaa992122790270bae77eb2e640ad40b12cf4R1560-R1561

    // Use same weights as substrate ones.
    type WeightInfo = pallet_state_trie_migration::weights::SubstrateWeight<Runtime>;

ggwpez commented 7 months ago

I'm just bringing this to your attention because last time it took somewhere between 12 to 23 hours on Oliver's machine (Kusama/Polkadot are the slowest - several hours, while SPs are fast). Maybe there's no need to regenerate for all runtimes, and we could just regenerate for the concrete pallets affected after commit f5aeb7e8cc024a17a42ca547645f25f2ae28e4f4?

I think we used the same weights for the state-trie-migration as on Kusama? So should be fine.
For the other pallet, yea we could regenerate if its quick, but would not want to hold up the release for it.

bkontur commented 7 months ago

I'm just bringing this to your attention because last time it took somewhere between 12 to 23 hours on Oliver's machine (Kusama/Polkadot are the slowest - several hours, while SPs are fast). Maybe there's no need to regenerate for all runtimes, and we could just regenerate for the concrete pallets affected after commit f5aeb7e8cc024a17a42ca547645f25f2ae28e4f4?

I think we used the same weights for the state-trie-migration as on Kusama? So should be fine. For the other pallet, yea we could regenerate if its quick, but would not want to hold up the release for it.

ok, I just did pallet_asset_conversion and pallet_treasury:

[x] https://github.com/polkadot-fellows/runtimes/pull/256

acatangiu commented 7 months ago

should we close this now?

bkontur commented 7 months ago

1.2.0 is released: https://github.com/polkadot-fellows/runtimes/releases/tag/v1.2.0, next https://github.com/polkadot-fellows/runtimes/issues/186

polkadot-fellows / runtimes

1.2.0 Release #140

TODO