Encointer checks/improvements

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.

GNU General Public License v3.0

127 stars 76 forks source link

Encointer checks/improvements #199

Open bkontur opened 4 months ago

bkontur commented 4 months ago

Check or fix

[ ] setup FeeManager according to other SP parachains, is it ok to have it like type FeeManager = (); ?
[ ] type IsReserve = NativeAsset; - do other chains send ReserveAssetDeposited to Encointer?

TODO

[ ] setup pallet_xcm benchmarks and replace type WeightInfo = pallet_xcm::TestWeightInfo;

cc: @brenzi

brenzi commented 4 months ago

yea, plz. assign this to me

bkontur commented 4 months ago

@brenzi I cannot assign, don't you have "assing yourself" button there? I guess nobody won't work on this :)

bkontur commented 4 months ago

@brenzi can you also please this PR https://github.com/bkontur/runtimes/pull/4 and review/approve? It contains your changes plus few my nits.

bkontur commented 4 months ago

@brenzi When do you think you could check this? At the very least, setting up pallet_xcm benchmarks would be very useful.

brenzi commented 4 months ago

We'll take care within the next 4 weeks, among other related pending tasks for the runtime. I suggest not to wait for this for the release 1.2.0

brenzi commented 3 months ago

this will be easier to fix after the cleanup in https://github.com/polkadot-fellows/runtimes/pull/270 because fee handling is aligned with other system chains

clangenb commented 2 weeks ago

Is anything still open here?

bkontur commented 1 week ago

@brenzi what about this older one?

brenzi commented 1 week ago

the point on FeeAsset can be resolved I guess.

the IsReserve I'm not sure of there is need to change anything now.

do other chains send ReserveAssetDeposited to Encointer?

IsReserve is just a copy paste. All we need to be able to do currently is teleport KSM to/from relay or AssetHub. I have no strong opinion otherwise. Do you have a suggestion here?

The last point is still open: We don't have custom benchmarking for XCM yet. This slipped our last sprints. With the upcoming holiday season I can't promise a short term solution here. But it is on our list