polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
136 stars 89 forks source link

Fellowship salary payment over XCM failed #213

Closed ggwpez closed 7 months ago

ggwpez commented 7 months ago

Tried out FellowshipSalary::payout locally in chopsticks and it errors in XCM router validation.
This line in particular. Code deployed on collectives-polkadot should be 89fdefcc61d119 according to Cargo VCS lockfile.

The called wrap_version is getting a None from the get_version_for with dest arg of { parents: 1 }, which seems to cascade into the error return.

Minimized backtrace:

cumulus_pallet_xcmp_queue::<impl staging_xcm::v3::traits::SendXcm for cumulus_pallet_xcmp_queue::pallet::Pallet<T>>::validate (cumulus-pallet-xcmp-queue-0.7.0/src/lib.rs:917)
<(TupleElement0,TupleElement1) as staging_xcm::v3::traits::SendXcm>::validate (staging-xcm-7.0.0/src/v3/traits.rs:542)
<staging_xcm_builder::routing::WithUniqueTopic<Inner> as staging_xcm::v3::traits::SendXcm>::validate (staging-xcm-builder-7.0.3/src/routing.rs:52)
<staging_xcm_builder::pay::PayOverXcm<Interior,Router,Querier,Timeout,Beneficiary,AssetKind,AssetKindToLocatableAsset,BeneficiaryRefToLocation> as frame_support::traits::tokens::pay::Pay>::pay (staging-xcm-builder-7.0.3/src/pay.rs:128)
pallet_salary::pallet::Pallet<T,I>::do_payout (pallet-salary-13.0.0/src/lib.rs:438)
pallet_salary::pallet::Pallet<T,I>::payout::{{closure}} (pallet-salary-13.0.0/src/lib.rs:316)
pallet_salary::pallet::Pallet<T,I>::payout (pallet-salary-13.0.0/src/lib.rs:88)
bkontur commented 7 months ago

I think when these referenda are executed, it should work: https://github.com/polkadot-fellows/runtimes/issues/190

bkontur commented 7 months ago

This issue is exactly the same problem: https://github.com/polkadot-fellows/runtimes/issues/190#issuecomment-1947959182

bkchr commented 7 months ago

So we can close this?

ggwpez commented 7 months ago

Okay will re-open if that did not fix it.