search

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
126 stars 74 forks source link

Check `transaction_version` for 1.2.0 Release for all runtimes #250

Closed bkontur closed 3 months ago

bkontur commented 3 months ago

We need to compare actual master with lastest v1.1.2 or v1.1.3.

Similar older issue with some commands for Polkadot; https://github.com/polkadot-fellows/runtimes/issues/77 Relates to: https://github.com/polkadot-fellows/runtimes/issues/69

EgorPopelyaev commented 3 months ago

Results of the transaction_version check 1.1.3 VS. master. Full report based on runtimes comparison generated by subwasm differ: Extrinsic_ordering_check_100200.md There are some calls deletions noticed which might be a reason for the bump for the following runtimes:

Polkadot AssetHub changes:
[≠] pallet 30: XcmpQueue
  - calls changes:
    [-] "service_overweight"
    [-] "update_threshold_weight"
    [-] "update_weight_restrict_decay"
    [-] "update_xcmp_max_individual_weight"

[≠] pallet 33: DmpQueue
  - calls changes:
    [-] "service_overweight"

Polkadot BridgeHub chanegs:
[≠] pallet 30: XcmpQueue
  - calls changes:
    [-] "service_overweight"
    [-] "update_threshold_weight"
    [-] "update_weight_restrict_decay"
    [-] "update_xcmp_max_individual_weight"

[≠] pallet 33: DmpQueue
  - calls changes:
    [-] "service_overweight"

Polkadot Collectives changes:
[≠] pallet 30: XcmpQueue
  - calls changes:
    [-] "service_overweight"
    [-] "update_threshold_weight"
    [-] "update_weight_restrict_decay"
    [-] "update_xcmp_max_individual_weight"

[≠] pallet 33: DmpQueue
  - calls changes:
    [-] "service_overweight"

Kusama AssetHub chaneges:
[≠] pallet 30: XcmpQueue
  - calls changes:
    [-] "service_overweight"
    [-] "update_threshold_weight"
    [-] "update_weight_restrict_decay"
    [-] "update_xcmp_max_individual_weight"

[≠] pallet 33: DmpQueue
  - calls changes:
    [-] "service_overweight"

Kusama BridgeHub changes:
[≠] pallet 30: XcmpQueue
  - calls changes:
    [-] "service_overweight"
    [-] "update_threshold_weight"
    [-] "update_weight_restrict_decay"
    [-] "update_xcmp_max_individual_weight"

[≠] pallet 33: DmpQueue
  - calls changes:
    [-] "service_overweight"

Kusama Encointer changes:
[≠] pallet 10: Balances
  - calls changes:
    [-] "set_balance_deprecated"
    [-] "transfer"

 [≠] pallet 30: XcmpQueue
  - calls changes:
    [-] "service_overweight"
    [-] "update_threshold_weight"
    [-] "update_weight_restrict_decay"
    [-] "update_xcmp_max_individual_weight"

[≠] pallet 33: DmpQueue
  - calls changes:
    [-] "service_overweight"
xlc commented 3 months ago

call deletion doesn’t require tx version bump

acatangiu commented 3 months ago

Let's close this as complete

bkchr commented 3 months ago

Checked the output, looks like nothing changed.