`im-online` session keys migration will not run on Kusama

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.

GNU General Public License v3.0

135 stars 85 forks source link

`im-online` session keys migration will not run on Kusama #262

Closed s0me0ne-unkn0wn closed 6 months ago

s0me0ne-unkn0wn commented 6 months ago

We have a Kusama runtime upgrade to 1.1.3 on track that will be enacted soon: https://kusama.subsquare.io/referenda/359

That will prevent the execution of the session keys migration in 1.2.0 release: https://github.com/polkadot-fellows/runtimes/blob/2dd830a4e30538836198a4d4eaf68da686a0ef3e/relay/kusama/src/lib.rs#L1863

CC @bkchr

bkchr commented 6 months ago

Good find. Can you please make a pr to fix this? Then we need to revert the release once more 🙈

s0me0ne-unkn0wn commented 6 months ago

Can you please make a pr to fix this?

Sure. The question is, do I need to fix it for Polkadot as well? I'm not sure if the Polkadot upgrade pipeline strictly follows Kusama's one. Like, if we have 1.1.2 -> 1.1.3 -> 1.2.0 on Kusama, is it exactly the same for Polkadot? (I mean in the best-case scenario when OpenGov approves those changes)

bkchr commented 6 months ago

The upgrade will also be applied for polkadot https://polkadot.polkassembly.io/referenda/581