Closed joepetrowski closed 3 months ago
Review required! Latest push from author must always be reviewed
Looking ready, just a few small things below.
people-polkadot
is also missing fromruntimes-matrix.json
.I also didn't check the weights as they seem to be unchanged from
people-kusama
. Will you run the benchmarks in this PR or elsewhere? Would be a good check to make sure the factor of two is sufficient between relay and para in case the ratio is very different on Polkadot
@joepetrowski @seadanda fresh weights and fixes are ready here: https://github.com/joepetrowski/runtimes/pull/2
/merge
Enabled auto-merge
in Pull Request
I found there are too many duplicated code for a new system parachain. This is a code smell and should be addressed at some stage. We will have more system parachains and we need to reduce the overhead of making one before making more system parachains.
@xlc would be good to get your input on https://github.com/paritytech/polkadot-sdk/issues/4815 as a first step towards minimising the diff between system parachains
Polkadot People Chain
To verify prior to release: People Chain
poke_deposit
weight must be less than 2x Relay's. E.g.: