search

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
125 stars 72 forks source link

Identify duplicated code and merge them #336

Open xlc opened 1 month ago

xlc commented 1 month ago 
          I found there are too many duplicated code for a new system parachain. This is a code smell and should be addressed at some stage. We will have more system parachains and we need to reduce the overhead of making one before making more system parachains.

Originally posted by @xlc in https://github.com/polkadot-fellows/runtimes/pull/319#pullrequestreview-2087645551

joepetrowski commented 1 month ago

There isn't very much overhead, can set up a new one in a morning. Feel free to make a PR but we (Parity) have already had a lot of people restructure code to have less duplication where it makes sense.