search

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
125 stars 72 forks source link

Explicit default for testnet `HostConfiguration` #362

Open ggwpez opened 4 days ago

ggwpez commented 4 days ago

A ..Default::default() here is hiding newly added fields.
Maybe someone should take a look if these values are sane and add explicit default so that it fails in the future instead of using 0.

dharjeezy commented 2 days ago

For this, are you saying we specify each property and provide them with their default one by one?

ggwpez commented 1 day ago

Yea, but i dont know what values are good defaults.