search

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
143 stars 97 forks source link

Check `merge bot` and required pipelines #396

Closed bkontur closed 3 months ago

bkontur commented 3 months ago

E.g. this PR was merged but one pipeline integration-test (bridge-hub-kusama, bridge-hub-kusama-integration-tests) failed, how is that possible?

image

bkontur commented 3 months ago

cc: @Bullrich

Bullrich commented 3 months ago

The parameter continue-on-error: true seems to be the offender.

We should remove it in both places:

bkontur commented 3 months ago

I removed continue-on-error: true here: https://github.com/polkadot-fellows/runtimes/pull/397 and I will also add a fix.

Maybe fail-fast: false looks better: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

bkontur commented 3 months ago

definitely, continue-on-error: true is not good, because tests failed and this pipeline passed :) image

bkontur commented 3 months ago

@Bullrich I removed continue-on-error: true and now that pipeline confirmTestPassed is marked as a skipped: Test all features / All tests passed (pull_request) Skipped

image

So, is that confirmTestPassed marked as a required to block merge in the github configuration?

Bullrich commented 3 months ago

It is working as intended, well done!

image

So, is that confirmTestPassed marked as a required to block merge in the github configuration?

Yes, we need to mark that test as the required one.

bkchr commented 3 months ago

Marked all the "All ****" as required.

bkontur commented 3 months ago

Fixed by https://github.com/polkadot-fellows/runtimes/pull/397