search

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
143 stars 97 forks source link

Review bot error: Reviews may only be requested from collaborators #405

Closed ggwpez closed 3 months ago

ggwpez commented 4 months ago

CI from here: 

gh: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the polkadot-fellows/runtimes repository. (HTTP 422)
{"message":"Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the polkadot-fellows/runtimes repository.","documentation_url":"https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request","status":"422"}
Error: Process completed with exit code 1.

cc @Bullrich

seadanda commented 3 months ago

Looks like this is related to the migration to the People Chain - identities are off the relay and now the bot thinks that nobody is a collaborator (there are no Github handles where it's looking). I haven't looked into the bot code yet but if you look at the logs for the "Get github handle of the fellows stage" it doesn't even connect to Polkadot People.

Also compare that stage of the action to the most recent PR merged to main which must have run before the identities were removed and you can see that #381 doesn't find the Github handles, but the stage is still passing. It then fails later because nobody who has reviewed it is in the list of ""s.

seadanda commented 3 months ago

Looks like it is now fixed: https://github.com/paritytech/review-bot/pull/131

Pending release and confirmation that this is the same cause

ggwpez commented 3 months ago

Yea waiting for approvals here now: https://github.com/polkadot-fellows/runtimes/pull/409

bkchr commented 3 months ago

I have seen the error message before. The migration also happened at the 28th AFAIK.

seadanda commented 3 months ago

Yea the same error would be triggered if somebody outside the fellowship (or not listed as a collaborator) reviewed the PR before it was changed. Seems like getting the list of collaborators from the GitHub API and then using it to filter the list of reviewers before re-requesting a review would sort it.

ggwpez commented 3 months ago

Fixed not it seems.