search

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
143 stars 97 forks source link

Actually benchmark `pallet_xcm::execute` for all runtimes #436

Closed franciscoaguirre closed 3 months ago

franciscoaguirre commented 3 months ago

We removed a filter to allow arbitrary XCM execution in the runtimes, but if you actually try to call pallet_xcm::execute you'll get an error saying you exceed max weight. This is because pallet_xcm::execute has max weight. This was done to disallow it, now we should benchmark it again.

This is the case for most runtimes in the repo.

bkontur commented 3 months ago

@franciscoaguirre yes, you're right, exactly, I saw this when I did fresh weights comparision today: https://github.com/polkadot-fellows/runtimes/pull/433 - all are regenerated (just kusama is missing, I will push in few hours)

franciscoaguirre commented 3 months ago

My bad, didn't see that PR 🙈