search

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
143 stars 97 forks source link

xcm benchmarking for encointer runtime #440

Closed brenzi closed 3 months ago

brenzi commented 3 months ago

closes #199

Add xcm benchmark setup for encointer-kusama-runtime

brenzi commented 3 months ago

@bkontur With the example of the people chain, I added XCM benchmarks to encointer, but pallet-xcm-benchmarks::generic fails because of skipped benchmarks, whereas people accepts these skips. I seem to be missing some config.

I did:

cargo build -p chain-spec-generator --profile production --features runtime-benchmarks
./target/production/chain-spec-generator --raw encointer-kusama-local > encointer-kusama-chain-spec.json
~/bin/polkadot-parachain-v1.14.0-runtime-benchmarks benchmark pallet --chain ./encointer-kusama-chain-spec.json --pallet=pallet-xcm-benchmarks::generic --extrinsic="*"

which throws errors. change encointer- to people- and it works

edit: fixed in 7d2e67c

bkchr commented 3 months ago

@brenzi could you please format the code correctly? CI is not happy :D

bkontur commented 3 months ago

@bkontur With the example of the people chain, I added XCM benchmarks to encointer, but pallet-xcm-benchmarks::generic fails because of skipped benchmarks, whereas people accepts these skips. I seem to be missing some config.

I did:

cargo build -p chain-spec-generator --profile production --features runtime-benchmarks
./target/production/chain-spec-generator --raw encointer-kusama-local > encointer-kusama-chain-spec.json
~/bin/polkadot-parachain-v1.14.0-runtime-benchmarks benchmark pallet --chain ./encointer-kusama-chain-spec.json --pallet=pallet-xcm-benchmarks::generic --extrinsic="*"

which throws errors. change encointer- to people- and it works

edit: fixed in 7d2e67c

@brenzi can you merge this one please: https://github.com/encointer/runtimes/pull/1 ? It fixes the benchmarks for pallet_xcm which fail here: https://github.com/polkadot-fellows/runtimes/actions/runs/10528553477/job/29174892572?pr=440 (and also I did fmt)

brenzi commented 3 months ago

@bkontur thanks for your fix. This also includes one-line changes in other systemchains (coretime and people). Was that on purpose? Seems out of context to this PR, but I don't mind

brenzi commented 3 months ago

/merge

fellowship-merge-bot[bot] commented 3 months ago

Enabled auto-merge in Pull Request

Available commands - `/merge`: Enables auto-merge for Pull Request - `/merge cancel`: Cancels auto-merge for Pull Request - `/merge help`: Shows this menu For more information see the [documentation](https://github.com/paritytech/auto-merge-bot)