polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
143 stars 97 forks source link

Asset Hubs: switch over to paying fees using auto-swaps #475

Open acatangiu opened 1 month ago

acatangiu commented 1 month ago

TakeFirstAssetTrader is still being used on Asset Hubs. This should be removed and rely solely on SwapFirstAssetTrader for paying fees with other assets than DOT/KSM.

TakeFirstAssetTrader was meant as a temporary solution until we have SwapFirstAssetTrader working and live swap pools with popular assets. The conditions are now right to remove TakeFirstAssetTrader.

The motivation to remove TakeFirstAssetTrader is that it doesn't (and can't) correctly account the economic value of weight. Depending on market movements, buying weight with sufficient assets can be abused to potentially severely undercut fees.

muharem commented 1 week ago

@acatangiu https://github.com/polkadot-fellows/runtimes/pull/502