search

polkadot-fellows / runtimes

The various runtimes which make up the core subsystems of networks for which the Fellowship is represented.
GNU General Public License v3.0
143 stars 97 forks source link

Location conversion tests for relay and parachains #487

Open x3c41a opened 1 month ago

x3c41a commented 1 month ago

Added location convertion tests. Polkadot sdk PR Fixes #488

x3c41a commented 1 month ago

bot fmt

x3c41a commented 1 month ago

The conversions are the same for all system parachains, so this test could be a macro to dedup the code, but I don't know where we would put that macro or if it's worth the effort. I'm fine with the duplicated code too.

Please see the other comments.

I don't feel like writing macros just yet, still want to get used to Rust.

github-actions[bot] commented 1 month ago

Review required! Latest push from author must always be reviewed