search

polkadot-fellows / xcm-format

Polkadot Cross Consensus-system Message format.
Apache License 2.0
181 stars 43 forks source link

RFC: Rename locking instructions #39

Open vstam1 opened 1 year ago

vstam1 commented 1 year ago

Summary

This RFC proposes renaming several XCM instructions to align with changes in Substrate naming. The following instructions and error are affected:

Instructions: LockAsset -> FreezeAsset UnlockAsset -> ThawAsset NoteUnlockable -> NoteThawable RequestUnlock -> RequestThaw

Error: LockError -> FreezeError

vstam1 commented 1 year ago

My main concern with this is that we want the wider ecosystem to adopt XCM, and the main terminology used is asset locking/unlocking. Imposing a new term for this could make adoption harder.

I do also think that keeping the old terminology is confusing once we updated from locking -> freezing in FRAME.

xlc commented 1 year ago

The XCM spec shouldn't care about FRAME. We may want to do the rename but the reason shouldn't be because FRAME did it. If anything, it is the FRAME should honor XCM's naming convention.