search

polkadot-fellows / xcm-format

Polkadot Cross Consensus-system Message format.
Apache License 2.0
181 stars 43 forks source link

Install Review GitHub app and set up secrets #65

Closed Bullrich closed 5 months ago

Bullrich commented 5 months ago

To properly install review-bot, like requested in https://github.com/polkadot-fellows/xcm-format/issues/62#issuecomment-2161233184, we first need to have the GitHub app used in the runtimes repository.

As you can see in the GitHub Action Review Bot, the secrets REVIEW_APP_ID and REVIEW_APP_KEY have been installed in that repository.

We need an admin to:

This are the required steps to install Review-Bot.

acatangiu commented 5 months ago

Who is admin over this org? @ggwpez @bkchr @shawntabrizi

bkchr commented 5 months ago

I'm confused. This is the wrong repo? The bot should be installed for the xcm-format repo or?

Bullrich commented 5 months ago

I'm confused. This is the wrong repo?

I understood from this comment between @acatangiu and @rzadp that xcm-format would be migrated into this repository:

they will have to migrate their RFCs from here to https://github.com/polkadot-fellows/RFCs

Was there been a different decision that is not reflected inside the issue?

acatangiu commented 5 months ago

We want to run the review bot on the https://github.com/polkadot-fellows/xcm-format repo, not this repo.

(point 2 in https://github.com/polkadot-fellows/xcm-format/issues/62#issuecomment-2161233184)

Bullrich commented 5 months ago

Ok, I got confused by the phrasing in the next comment.

@bkchr could you migrate this issue to the xcm-format repository please?

The requirements are still the same.

Thanks!

bkchr commented 5 months ago

@Bullrich can you give me the link to the docs on how to create the app ID and key? Then I get this done

Bullrich commented 5 months ago

@pavelsupr manages the bot in Parity's org, I remember that he provided both the app id and generated a private key when we installed it in the runtimes repository.

Pavel, could you please generate a new private key and share both the key and the app id with Basti for the app Parity-Review-Bot?

Once @bkchr has these, he can set them as repository secrets and then I can port the Review-Bot configuration file.

Thanks!

pavelsupr commented 5 months ago

Hey @Bullrich @bkchr , in the past the ReviewBot app id and key were already issued for the Fellowship org and provided to Basti. I'll send a copy of them to Basti once again via 1Password.

bkchr commented 5 months ago

Ty @pavelsupr.

@Bullrich I created the env variables as requested.

Bullrich commented 5 months ago

Ty @pavelsupr.

@Bullrich I created the env variables as requested.

Thank you. I created https://github.com/polkadot-fellows/xcm-format/pull/66

I tried to use more of the score system to make it more attractive for lower ranks to participate, but feel free to request any changes.