search

polkadot-js / api

Promise and RxJS APIs around Polkadot and Substrate based chains via RPC calls. It is dynamically generated based on what the Substrate runtime provides in terms of metadata.
Apache License 2.0
1.07k stars 354 forks source link

Support `minimumPeriod` of `0` #5826

Closed bkchr closed 8 months ago

bkchr commented 8 months ago

With the switch to async backing, parachains will set a minimumPeriod of 0. (Not all, but some).

This currently breaks transaction signing here: https://github.com/polkadot-js/api/blob/8dbc373ac573e8c7aea580e8d17d634e40f01956/packages/api-derive/src/tx/signingInfo.ts#L88

We should check that if minimumPeriod is 0 and then just also use the fallback duration. On top of that we should use SlotDuration from Aura: https://github.com/paritytech/polkadot-sdk/pull/3732 as we use ExpectedBlockTime from Babe.

bkchr commented 8 months ago

@TarikGul could we get a quick fix for this?

TarikGul commented 8 months ago

Just woke up :), @pepoviola - Thanks for the PR. Going to check it all right now!

TarikGul commented 8 months ago

rel: https://github.com/polkadot-js/apps/issues/9970

TarikGul commented 8 months ago

Once #5827 goes in we will do a patch release.

TarikGul commented 8 months ago

Released in 10.12.3

polkadot-js-bot commented 7 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.