polkadot-js / api

Promise and RxJS APIs around Polkadot and Substrate based chains via RPC calls. It is dynamically generated based on what the Substrate runtime provides in terms of metadata.
Apache License 2.0
1.06k stars 342 forks source link

fix: `CheckMetadataHash` `signedExtension` support #5882

Closed TarikGul closed 1 month ago

TarikGul commented 1 month ago

closes: https://github.com/polkadot-js/api/issues/5881 rel: https://github.com/paritytech/polkadot-sdk/pull/4274

Update:

Tested

Using Txwrapper-core to create the Payloads and to create a SubmittableExtrinsic and a SignedExtrinsic with it, in order to confirm this addition didn't break any historic compatibility.

TarikGul commented 1 month ago

Just as a note, @bee344 is going to take over adding this into the API to free up some resources for me so I can also finish some additional high priority bugs in Apps.

Thanks again @bee344 🙏

bkchr commented 1 month ago

@bee344 when are you planning to tackle this? I will also need this for my pr to pass CI :D

bee344 commented 1 month ago

@bkchr I'll do it today

bkchr commented 1 month ago

heads up @bee344 some last minute changes to the signed extension, the signed data is now an Option<Hash>

bee344 commented 1 month ago

Tested against https://github.com/paritytech/polkadot-sdk/tree/bkchr-metadata-hash

TarikGul commented 1 month ago

@bee344 Small nits. We should also add a test for in SignerPayload.spec.ts.

bee344 commented 1 month ago

Update: Tested against:

  1. https://github.com/paritytech/polkadot-sdk/tree/bkchr-metadata-hash
  2. Client v1.11.0 polkadot --dev
  3. Live Westend Relay Chain v1.11.0

Using Txwrapper-core to create the Payloads and to create a SubmittableExtrinsic and a SignedExtrinsic with it.

bkchr commented 1 month ago

@TarikGul @bee344 could I please get a release with this included?

TarikGul commented 1 month ago

@bkchr Yup, its scheduled to be released today :)

polkadot-js-bot commented 1 month ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.