search

polkadot-js / api

Promise and RxJS APIs around Polkadot and Substrate based chains via RPC calls. It is dynamically generated based on what the Substrate runtime provides in terms of metadata.
Apache License 2.0
1.07k stars 349 forks source link

fix: remove substrate connect as optional dependency #5889

Closed ryanleecode closed 4 months ago

ryanleecode commented 4 months ago

We only use substrate connect as types, so it doesn't need to be an optional dependency. This will solve weird issues inside the substrate connect repo where we have a different transitively dependency on the substrate connect version polkadot-js is tied to

➜  substrate-connect git:(main) corepack pnpm why -r @substrate/connect
Legend: production dependency, optional only, dev only

@substrate/burnr@0.0.0 /home/ryan/Documents/Repositories/substrate-connect/projects/burnr

dependencies:
@polkadot/api 10.13.1
├─┬ @polkadot/api-augment 10.13.1
│ └─┬ @polkadot/api-base 10.13.1
│   └─┬ @polkadot/rpc-core 10.13.1
│     └─┬ @polkadot/rpc-provider 10.13.1
│       └── @substrate/connect 0.8.8
├─┬ @polkadot/api-base 10.13.1
│ └─┬ @polkadot/rpc-core 10.13.1
│   └─┬ @polkadot/rpc-provider 10.13.1
│     └── @substrate/connect 0.8.8
├─┬ @polkadot/api-derive 10.13.1
│ ├─┬ @polkadot/api-augment 10.13.1
│ │ └─┬ @polkadot/api-base 10.13.1
│ │   └─┬ @polkadot/rpc-core 10.13.1
│ │     └─┬ @polkadot/rpc-provider 10.13.1
│ │       └── @substrate/connect 0.8.8
│ ├─┬ @polkadot/api-base 10.13.1
│ │ └─┬ @polkadot/rpc-core 10.13.1
│ │   └─┬ @polkadot/rpc-provider 10.13.1
│ │     └── @substrate/connect 0.8.8
│ └─┬ @polkadot/rpc-core 10.13.1
│   └─┬ @polkadot/rpc-provider 10.13.1
│     └── @substrate/connect 0.8.8
├─┬ @polkadot/rpc-core 10.13.1
│ └─┬ @polkadot/rpc-provider 10.13.1
│   └── @substrate/connect 0.8.8
└─┬ @polkadot/rpc-provider 10.13.1
  └── @substrate/connect 0.8.8
@polkadot/api-augment 10.13.1
└─┬ @polkadot/api-base 10.13.1
  └─┬ @polkadot/rpc-core 10.13.1
    └─┬ @polkadot/rpc-provider 10.13.1
      └── @substrate/connect 0.8.8
@polkadot/rpc-provider 11.0.3
└── @substrate/connect 0.8.10
@substrate/connect link:../../packages/connect

@substrate/demo@0.0.0 /home/ryan/Documents/Repositories/substrate-connect/projects/demo

dependencies:
@substrate/connect link:../../packages/connect

@substrate/wallet-template@0.0.1 /home/ryan/Documents/Repositories/substrate-connect/projects/wallet-template

dependencies:
@polkadot/extension-inject 0.46.9
├─┬ @polkadot/api 10.13.1 peer
│ ├─┬ @polkadot/api-augment 10.13.1
│ │ └─┬ @polkadot/api-base 10.13.1
│ │   └─┬ @polkadot/rpc-core 10.13.1
│ │     └─┬ @polkadot/rpc-provider 10.13.1
│ │       └── @substrate/connect 0.8.8
│ ├─┬ @polkadot/api-base 10.13.1
│ │ └─┬ @polkadot/rpc-core 10.13.1
│ │   └─┬ @polkadot/rpc-provider 10.13.1
│ │     └── @substrate/connect 0.8.8
│ ├─┬ @polkadot/api-derive 10.13.1
│ │ ├─┬ @polkadot/api-augment 10.13.1
│ │ │ └─┬ @polkadot/api-base 10.13.1
│ │ │   └─┬ @polkadot/rpc-core 10.13.1
│ │ │     └─┬ @polkadot/rpc-provider 10.13.1
│ │ │       └── @substrate/connect 0.8.8
│ │ ├─┬ @polkadot/api-base 10.13.1
│ │ │ └─┬ @polkadot/rpc-core 10.13.1
│ │ │   └─┬ @polkadot/rpc-provider 10.13.1
│ │ │     └── @substrate/connect 0.8.8
│ │ └─┬ @polkadot/rpc-core 10.13.1
│ │   └─┬ @polkadot/rpc-provider 10.13.1
│ │     └── @substrate/connect 0.8.8
│ ├─┬ @polkadot/rpc-core 10.13.1
│ │ └─┬ @polkadot/rpc-provider 10.13.1
│ │   └── @substrate/connect 0.8.8
│ └─┬ @polkadot/rpc-provider 10.13.1
│   └── @substrate/connect 0.8.8
└─┬ @polkadot/rpc-provider 10.13.1
  └── @substrate/connect 0.8.8

zombienet-tests@0.0.1 /home/ryan/Documents/Repositories/substrate-connect/zombienet-tests
polkadot-js-bot commented 4 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.