search

polkadot-js / apps

Basic Polkadot/Substrate UI for interacting with a Polkadot and Substrate node. This is the main user-facing application, allowing access to all features available on Substrate chains.
https://dotapps.io
Apache License 2.0
1.74k stars 1.53k forks source link

Staking Page Missing in Polkadex UI After Latest Changes #10505

Closed nuel77 closed 4 months ago

nuel77 commented 4 months ago

Hello.

I wanted to bring up an issue that we've noticed in the Polkadex UI after the recent changes from PR #10498 on the polkadot-js/apps repository.

It seems that the staking page section is now missing in Polkadex UI following these updates. I understand that there was a significant change introduced for pallet-staking in the new version, which might have caused this discrepancy.

My main question is whether the apps-ui team has any plans for providing backwards compatibility to address this issue, or if the fix requires upgrading to the latest version of substrate. Understanding the roadmap for resolving this would be immensely helpful for our next steps.

Looking forward to hearing your insights on this matter!

apps-ui central domain(staking page missing)

image

apps-ui ipfs doiman (still working)

image
kdembler commented 4 months ago

Joystream is facing the same issue (Redirecting from route "/staking" to "/explorer", missing the following APIs: ["query.staking.erasStakersOverview"]) due to older staking runtime pallet. Hopefully this page could be made backwards compatible, otherwise we will need to host old version of apps ourselves.

kdembler commented 4 months ago

@jacogr @TarikGul

TarikGul commented 4 months ago

My main question is whether the apps-ui team has any plans for providing backwards compatibility to address this issue, or if the fix requires upgrading to the latest version of substrate. Understanding the roadmap for resolving this would be immensely helpful for our next steps.

First apologies on any issues this causes. Usually speaking I would aim from the start to ensure backwards compatibility but this specific problem with the new staking changes was a pretty wide net that extended from the @polkadot/api-derive package all the way to apps. So it wasn't as simple as providing compatibility in just the UI. Also it's hard to track every chain and what they use, especially when things become urgent.

The compatibility on the api level is the hardest here, as that is where all the observable calls, aggregation, and structuring happens for all the information that the staking UI leverages.

Hopefully this page could be made backwards compatible, otherwise we will need to host old version of apps ourselves.

This is never a bad idea.

That all being said, I am OOO for the next week (including today), but when back I will try to look into potential solutions to bring this compatibility solution to a more manageable and maintainable path moving forward. Maybe the best most reasonable solution (for now) is bringing compatibility to the api-derive staking level first, and just make a copy of the old staking page, call it staking-legacy, and alias the text to be staking in the UI so the experience feels the same.

marc-aurele-besner commented 4 months ago

In the meantime, anyone can use the Old IPFS CID 😄

PdexFan commented 4 months ago

In the meantime, anyone can use the Old IPFS CID 😄

I can confirm that this solution is not working for Polkadex Main Network.

marc-aurele-besner commented 4 months ago

In the meantime, anyone can use the Old IPFS CID 😄

I can confirm that this solution is not working for Polkadex Main Network.

I apologize if this solution doesn't help you. An ex-colleague had asked me how to find an old IPFS version of the app due to issues with the current app affecting him on another network, so I thought I would share this link here as well.

For reference, see the CID Log History if needing older CID

TarikGul commented 4 months ago

@nuel77 Just as a heads up I am now tackling this along with fixing staking for the relay chains simultaneously. Hopefully this will all be fixed on the API level today, then I can start tackling the UI bits.

nuel77 commented 4 months ago

Thanks a lot for the update @TarikGul , looking forward to it 🥂

MoyStell74 commented 4 months ago

Good morning everyone, I'm in the same situation, I can't see my goal on the mainet page polkadot.js polkadex network....I trust the team for a prompt update. We are aware Success

TarikGul commented 4 months ago

The basis for backwards compatibility was merged into the API yesterday https://github.com/polkadot-js/api/pull/5868, I just have one more porblem to tackle in the API to fix for claimed rewards with the new staking pallet then the changes will be released and reflected in apps.

MoyStell74 commented 4 months ago

La base para la compatibilidad con versiones anteriores se fusionó en la API ayer polkadot-js/api#5868 . Solo tengo un problema más que abordar en la API para solucionar las recompensas reclamadas con la nueva paleta de apuestas, luego los cambios se publicarán y se reflejarán en las aplicaciones. .

I have been using the polkadex mainnet in polkadot.js for staking since 2021 and for about 3 weeks I have not been able to see the staking section on the network. I can't make validator changes I can't add more pdex I can't withdraw I can only make transactions with my rewards. Can you tell me if this is going to be updated or is there another way to enter? please thank you

TarikGul commented 4 months ago

@MoyStell74 Yes, I am currently working on it as we speak: https://github.com/polkadot-js/apps/pull/10553

MoyStell74 commented 4 months ago

@MoyStell74Sí, actualmente estoy trabajando en ello mientras hablamos: #10553 THANK YOU

TarikGul commented 4 months ago

@MoyStell74 If you really need to access the staking page for polkadex you can just run apps locally, at the commit before the changes.

The commit is ca3f368d47d381e128435ebb6dc587b704940bd1

You just need to pull down apps, and run the following.

$ git checkout ca3f368d47d381e128435ebb6dc587b704940bd1
$ yarn install && yarn start

Then go to http://localhost:3000/?rpc=wss%3A%2F%2Fpolkadex-mainnet-rpc.dwellir.com#/staking

And it will work as it previously did.

nuel77 commented 4 months ago

La base para la compatibilidad con versiones anteriores se fusionó en la API ayer polkadot-js/api#5868 . Solo tengo un problema más que abordar en la API para solucionar las recompensas reclamadas con la nueva paleta de apuestas, luego los cambios se publicarán y se reflejarán en las aplicaciones. .

I have been using the polkadex mainnet in polkadot.js for staking since 2021 and for about 3 weeks I have not been able to see the staking section on the network. I can't make validator changes I can't add more pdex I can't withdraw I can only make transactions with my rewards. Can you tell me if this is going to be updated or is there another way to enter? please thank you

@MoyStell74 you can also try this which is an a old version of the apps UI hosted by the PolkaGate team. if you are facing any emergency use case.

TarikGul commented 4 months ago

PR is up and basically donte to fix the missing staking page: https://github.com/polkadot-js/apps/pull/10557

The tab is the same the only difference is the routing which is now legacy-staking

TarikGul commented 4 months ago

Feel free to test it locally if you would like!

TarikGul commented 4 months ago

This is now fixed in the live version!

nuel77 commented 4 months ago

Thanks alot @TarikGul 👍

polkadot-js-bot commented 4 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.