search

polkadot-js / apps

Basic Polkadot/Substrate UI for interacting with a Polkadot and Substrate node. This is the main user-facing application, allowing access to all features available on Substrate chains.
https://dotapps.io
Apache License 2.0
1.75k stars 1.54k forks source link

Allow multisig wallets creation with 1/3 threshold #3862

Open rrtti opened 3 years ago

rrtti commented 3 years ago

Currently, thresholds cannot be 1 for multisig wallets(Substrate checks for 2 when executing, so 1 would create an invalid multisig) but there is a feature in FRAME multisig module already to allow multisig with 1/3 threshold: https://github.com/paritytech/substrate/blob/6017c2a04b88cc650334d5d921200a89a3267c5a/frame/multisig/src/lib.rs#L244

filippoweb3 commented 2 years ago

@jacogr I was experimenting with the extrinsic tab and the asMultiThreshold1 does not work because it is not possible to create a multisig with Threshold = 1. I noticed that there is a closed issue on this topic. I posted this on the stack exchange. Would it be possible to fix the issue or remove the functionality on the extrinsic tab, since on Westend I lost a bunch of tokens and I bet people lost DOTs doing the same. The UI does not protect users for using non-working features.

jacogr commented 2 years ago

The UI extrinsic tab exposes all the on-chain extrinsics from the metadata. It is up to the user to construct those in the right form and certainly order if they wish to use it directly. (This is generally developer focussed, it is unfiltered and will stay that way)